Minor optimization for XMPPIDTracker - only fetch the elementID once.

robbiehanson · robbiehanson · commit 1c079eac9493 · 2014-07-31T15:34:55.000-07:00
diff --git a/Utilities/XMPPIDTracker.m b/Utilities/XMPPIDTracker.m
@@ -171,11 +171,12 @@ - (BOOL)invokeForElement:(XMPPElement *)element withObject:(id)obj
 {
     AssertProperQueue();
     
-    if([[element elementID] length] == 0) return NO;
+	NSString *elementID = [element elementID];
 	
-	id <XMPPTrackingInfo> info = [dict objectForKey:[element elementID]];
-    
-    if(info)
+	if ([elementID length] == 0) return NO;
+	
+	id <XMPPTrackingInfo> info = [dict objectForKey:elementID];
+	if(info)
     {
         BOOL valid = YES;
             

Original file line number	Diff line number	Diff line change
`@@ -171,11 +171,12 @@ - (BOOL)invokeForElement:(XMPPElement *)element withObject:(id)obj`
`171`	`171`	`{`
`172`	`172`	`AssertProperQueue();`
`173`	`173`
`174`		`- if([[element elementID] length] == 0) return NO;`
	`174`	`+ NSString *elementID = [element elementID];`
`175`	`175`
`176`		`- id <XMPPTrackingInfo> info = [dict objectForKey:[element elementID]];`
`177`		`-`
`178`		`- if(info)`
	`176`	`+ if ([elementID length] == 0) return NO;`
	`177`	`+`
	`178`	`+ id <XMPPTrackingInfo> info = [dict objectForKey:elementID];`
	`179`	`+ if(info)`
`179`	`180`	`{`
`180`	`181`	`BOOL valid = YES;`
`181`	`182`