A little bit of code modernization: converting enums to NS_ENUM.

Author: robbiehanson

Authentication/XMPPSASLAuthentication.h

@@ -6,18 +6,16 @@
 @class XMPPStream;
 
 
-enum XMPPHandleAuthResponse
-{
+typedef NS_ENUM(NSInteger, XMPPHandleAuthResponse) {
+	
 	XMPP_AUTH_FAIL,     // Authentication failed.
 	                    // The delegate will be informed via xmppStream:didNotAuthenticate:
 
 	XMPP_AUTH_SUCCESS,  // Authentication succeeded.
 	                    // The delegate will be informed via xmppStreamDidAuthenticate:
 
 	XMPP_AUTH_CONTINUE, // The authentication process is still ongoing.
-	
 };
-typedef enum XMPPHandleAuthResponse XMPPHandleAuthResponse;
 
 
 @protocol XMPPSASLAuthentication <NSObject>
@@ -80,7 +78,7 @@ typedef enum XMPPHandleAuthResponse XMPPHandleAuthResponse;
  * If the authentication is not yet complete, it should return XMPP_AUTH_CONTINUE,
  * meaning the xmpp stream will continue to forward all incoming xmpp stanzas to this method.
  * 
- * This method is called by automatically XMPPStream (via the authenticate: method).
+ * This method is called automatically by XMPPStream (via the authenticate: method).
  * You should NOT invoke this method manually.
 **/
 - (XMPPHandleAuthResponse)handleAuth:(NSXMLElement *)auth;

Core/XMPPInternal.h

@@ -6,8 +6,7 @@
 #import "XMPPModule.h"
 
 // Define the various states we'll use to track our progress
-enum XMPPStreamState
-{
+typedef NS_ENUM(NSInteger, XMPPStreamState) {
 	STATE_XMPP_DISCONNECTED,
 	STATE_XMPP_RESOLVING_SRV,
 	STATE_XMPP_CONNECTING,
@@ -22,7 +21,6 @@ enum XMPPStreamState
 	STATE_XMPP_START_SESSION,
 	STATE_XMPP_CONNECTED,
 };
-typedef enum XMPPStreamState XMPPStreamState;
 
 /**
  * It is recommended that storage classes cache a stream's myJID.

Core/XMPPStream.m

@@ -93,7 +93,7 @@ @interface XMPPStream ()
 
 	GCDMulticastDelegate <XMPPStreamDelegate> *multicastDelegate;
 
-	int state;
+	XMPPStreamState state;
 
 	GCDAsyncSocket *asyncSocket;
 
@@ -287,7 +287,7 @@ - (XMPPStreamState)state
 	__block XMPPStreamState result = STATE_XMPP_DISCONNECTED;
 
 	dispatch_block_t block = ^{
-		result = (XMPPStreamState)state;
+		result = state;
 	};
 
 	if (dispatch_get_specific(xmppQueueTag))