Skip to content

Commit c17d4c7

Browse files
committed
Fix texture saving not propagating the right settings
1 parent dd80af8 commit c17d4c7

File tree

2 files changed

+10
-0
lines changed

2 files changed

+10
-0
lines changed

qrenderdoc/Windows/Dialogs/TextureSaveDialog.cpp

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,11 +77,17 @@ TextureSaveDialog::TextureSaveDialog(const TextureDescription &t, const TextureS
7777
ui->mipSelect->addItem(
7878
QFormatStr("%1 - %2x%3").arg(i).arg(qMax(1U, tex.width >> i)).arg(qMax(1U, tex.height >> i)));
7979

80+
// reset as it might have been changed by adding items
81+
saveData.mip = s.mip;
82+
8083
ui->mipSelect->setCurrentIndex(saveData.mip >= 0 ? saveData.mip : 0);
8184

8285
for(uint32_t i = 0; i < tex.msSamp; i++)
8386
ui->sampleSelect->addItem(tr("Sample %1").arg(i));
8487

88+
// reset as it might have been changed by adding items
89+
saveData.sample = s.sample;
90+
8591
ui->sampleSelect->setCurrentIndex(qMin(
8692
(int)tex.msSamp, (saveData.sample.sampleIndex == ~0U ? 0 : (int)saveData.sample.sampleIndex)));
8793

@@ -114,6 +120,9 @@ TextureSaveDialog::TextureSaveDialog(const TextureDescription &t, const TextureS
114120
}
115121
}
116122

123+
// reset as it might have been changed by adding items
124+
saveData.slice = s.slice;
125+
117126
ui->sliceSelect->setCurrentIndex(saveData.slice.sliceIndex >= 0 ? saveData.slice.sliceIndex : 0);
118127

119128
ui->gridWidth->setMaximum(tex.depth * tex.arraysize * tex.msSamp);

qrenderdoc/Windows/TextureViewer.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3337,6 +3337,7 @@ void TextureViewer::on_saveTex_clicked()
33373337

33383338
TextureSave config;
33393339
memset(&config, 0, sizeof(config));
3340+
config.jpegQuality = 90;
33403341

33413342
config.id = m_TexDisplay.texid;
33423343
config.typeHint = m_TexDisplay.typeHint;

0 commit comments

Comments
 (0)