Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: micropython/micropython-lib
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: codemee/micropython-lib
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 5 commits
  • 1 file changed
  • 1 contributor

Commits on Dec 6, 2024

  1. Use the host in the redirect url, not the one in headers.

    The host in headers extracted from the original url may not be the same as the host in the redirect url. Poping out the host in headers force the code to use the host in the redirect url, otherwise the redirect may fail due to inconsistence of hosts in the original url and the redirect url.
    
    Signed-off-by: 黃昕暐 <[email protected]>
    codemee authored Dec 6, 2024
    Configuration menu
    Copy the full SHA
    822b340 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2025

  1. pop the item "Host" in the efficient way

    Use `headers.pop("Host", None)` instead of a `if` statement.
    
    Signed-off-by: 黃昕暐 <[email protected]>
    codemee authored Apr 11, 2025
    Configuration menu
    Copy the full SHA
    1e68c60 View commit details
    Browse the repository at this point in the history
  2. python-ecosys/requests/requests/__init__.py: update comment about the…

    … "Host" header in the redirect URL
    
    Update the comment to explain the reason for poping out "Host" header from headers. Ths host in the redirect URL may not be the same as the original URL, pop out "Host" in headers before redirect would force using the host specified in the redirect URL.
    
    Signed-off-by: 黃昕暐 <[email protected]>
    codemee authored Apr 11, 2025
    Configuration menu
    Copy the full SHA
    68fb277 View commit details
    Browse the repository at this point in the history
  3. requests: update comment about the "Host" header

    Update the comment to explain the reason for poping out
    "Host" header from headers. Ths host in the redirect URL
    may not be the same as the original URL, pop out "Host" in
    headers before redirect would force using the host specified
    in the redirect URL.
    
    Signed-off-by: 黃昕暐 <[email protected]>
    codemee committed Apr 11, 2025
    Configuration menu
    Copy the full SHA
    4616dba View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c707145 View commit details
    Browse the repository at this point in the history
Loading