Bug #22107047: "MYSQLD --HELP --VERBOSE" CREATES A FILE IN THE DATA DIRECTORY

This patch makes the server skip opening the binlog index file
if starting with --help.

Without this patch, with an empty data directory, the binlog
index file will be created and left in the data directory.
If we then do 'mysqld --initialize' on the same data directory,
it will fail.

Author: ssorumgard

mysql-test/r/help_verbose.result

@@ -5,3 +5,6 @@ Pattern "\[ERROR\]" not found
 # There should be no leftovers in the datadir.
 # There should be no errors
 Pattern "\[ERROR\]" not found
+# There should be no errors
+Pattern "\[ERROR\]" not found
+# There should be no leftovers in the datadir.

mysql-test/t/help_verbose.test

@@ -72,3 +72,29 @@
 # Cleanup
 --remove_files_wildcard $BUGDIR *
 --rmdir $BUGDIR
+
+###########################################################################
+# 4. Run --help --verbose and --log-bin on an existing but empty datadir.
+###########################################################################
+
+--let $BUGDIR=           $MYSQL_TMP_DIR/help_verbose_tc4
+--let $LOG_FILE =        $BUGDIR/mysqld.log
+--let $TEST_DATADIR=     $BUGDIR/data
+
+--mkdir $BUGDIR
+--mkdir $TEST_DATADIR
+
+--exec $MYSQLD --no-defaults --help --verbose --log-bin --server-id=1 --datadir=$TEST_DATADIR --lc-messages-dir=$MESSAGES_DIR  --secure-file-priv="" > $LOG_FILE 2>&1
+
+--echo # There should be no errors
+--let SEARCH_FILE=    $LOG_FILE
+--let SEARCH_PATTERN= \[ERROR\]
+--source include/search_pattern.inc
+
+--echo # There should be no leftovers in the datadir.
+--list_files $TEST_DATADIR
+
+# Cleanup
+--remove_files_wildcard $BUGDIR *
+--rmdir $TEST_DATADIR
+--rmdir $BUGDIR

sql/mysqld.cc

@@ -3857,7 +3857,13 @@ a file name for --log-bin-index option", opt_binlog_index_name);
       opt_bin_logname=my_strdup(key_memory_opt_bin_logname,
                                 buf, MYF(0));
     }
-    if (mysql_bin_log.open_index_file(opt_binlog_index_name, ln, TRUE))
+
+    /*
+      Skip opening the index file if we start with --help. This is necessary
+      to avoid creating the file in an otherwise empty datadir, which will
+      cause a succeeding 'mysqld --initialize' to fail.
+    */
+    if (!opt_help && mysql_bin_log.open_index_file(opt_binlog_index_name, ln, TRUE))
     {
       unireg_abort(MYSQLD_ABORT_EXIT);
     }