Skip to content

Commit 6623ee7

Browse files
committed
Bug #22041346 - SOME MTR OPTIONS USED IN COLLECTIONS FILES SHOULD BE DOCUMENTED IN README
More explanatory text added and some minror adjustments
1 parent 87b2221 commit 6623ee7

File tree

1 file changed

+32
-3
lines changed

1 file changed

+32
-3
lines changed

mysql-test/collections/README

Lines changed: 32 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
This directory contains collections of test runs that we run during our
22
integration and release testing. These files are not directly useful
33
outside this context, but need to be part of the source repository
4-
and are included for reference.Each file contains zero or more lines,
4+
and are included for reference. Each file contains zero or more lines,
55
with one invocation of mysql-test-run.pl on each. These invocations are
66
written so that, with the assumption that perl is in your search path,
7-
any collection can run as a shell script or a batch file, with the parent
8-
mysql-test directory being the current working directory.
7+
any collection can in principle run as a shell script or a batch file,
8+
with the parent mysql-test directory being the current working directory.
99

1010
During integration testing, we choose the collection to run by following
1111
these steps:
@@ -19,6 +19,9 @@ these steps:
1919
testing plus the extension as determined in step 1, we choose that
2020
collection.
2121

22+
2b) If we are running a valgrind test and there is a collection with
23+
the chosen name and the suffix "-valgrind" we choose that instead.
24+
2225
3) If the branch is unknown or we have removed all characters from it
2326
and still not found a matching collection, we choose the name "default"
2427
plus the extension determined in step 1. If there is no such file,
@@ -38,3 +41,29 @@ CMake will create a new file without the .in suffix where
3841
the include lines are replaced with the contents of the referred
3942
file. Filename is local to the collections directory, and includes do
4043
not nest.
44+
45+
Notes on some of the mysql-test-run.pl arguments and how they work in
46+
our continous intergation test framework. These are mostly for those
47+
writing or editing such files as they are specific to that setup.
48+
49+
1) The --comment argument produces a header which is parsed by the log
50+
analyzer to produce an entry for the result summary, seen as the
51+
name of the test batch. The names should be unique. Also, avoid too
52+
long names as it may clutter the presentation.
53+
54+
2) Do not use --mem, use --vardir instead. Before the test is run, a
55+
host specific ramdisk path is prepended to the vardir argument to
56+
ensure that tests always run on ramdisk. This also works on Windows
57+
or Mac OSX where --mem is not supported.
58+
59+
3) The name of the --vardir directory must start with 'var' in order for
60+
the test results to be correctly included in the result
61+
tarballs. They should also be unique across the collection file to
62+
avoid clashes. If --vardir is not specified, the --comment name will
63+
be used with a prefix "var-".
64+
65+
4) Any --parallel setting will be overridden by a host specific
66+
setting (which may be modified by branch; e.g. some hosts may need a
67+
lower setting for cluster). Most hosts use 8. It does not hurt to
68+
add --parallel=auto but this will only have effect should we have
69+
forgotten to set a parallel setting for a host.

0 commit comments

Comments
 (0)