Adding validation on ResultSet header argument

Author: nyamsprod

src/Reader.php

@@ -316,7 +316,7 @@ protected function computeHeader(array $header)
             return $header;
         }
 
-        throw new SyntaxError('The header record must be empty or a flat array with unique string values');
+        throw new SyntaxError('The header record must be an empty or a flat array with unique string values.');
     }
 
     /**

src/ResultSet.php

@@ -52,9 +52,20 @@ class ResultSet implements Countable, IteratorAggregate, JsonSerializable
     public function __construct(Iterator $records, array $header)
     {
         $this->records = $records;
+        $this->validateHeader($header);
         $this->header = $header;
     }
 
+    /**
+     * @throws SyntaxError if the header syntax is invalid
+     */
+    protected function validateHeader(array $header): void
+    {
+        if ($header !== array_unique(array_filter($header, 'is_string'))) {
+            throw new SyntaxError('The header record must be an empty or a flat array with unique string values.');
+        }
+    }
+
     /**
      * {@inheritdoc}
      */
@@ -86,6 +97,7 @@ public function getIterator(): Generator
      */
     public function getRecords(array $header = []): Generator
     {
+        $this->validateHeader($header);
         $records = $this->combineHeader($header);
         foreach ($records as $offset => $value) {
             yield $offset => $value;

tests/ReaderTest.php

@@ -183,7 +183,7 @@ public function testCall(): void
         $csv = Reader::createFromFileObject($file);
         $csv->setHeaderOffset(0);
 
-        $res = (new Statement())->process($csv);
+        $res = Statement::create()->process($csv);
         self::assertEquals($csv->fetchOne(3), $res->fetchOne(3));
         self::assertEquals($csv->fetchColumn('firstname'), $res->fetchColumn('firstname'));
         self::assertEquals($csv->fetchPairs('lastname', 0), $res->fetchPairs('lastname', 0));

tests/ResultSetTest.php

@@ -16,6 +16,7 @@
 use League\Csv\InvalidArgument;
 use League\Csv\Reader;
 use League\Csv\Statement;
+use League\Csv\SyntaxError;
 use OutOfBoundsException;
 use PHPUnit\Framework\TestCase;
 use SplTempFileObject;
@@ -193,7 +194,8 @@ public function testIntervalThrowException(): void
      * @covers League\Csv\Statement::where
      * @covers League\Csv\Statement::create
      * @covers League\Csv\Statement::process
-     * @covers League\Csv\Statement::combineHeader
+     * @covers League\Csv\ResultSet::combineHeader
+     * @covers League\Csv\ResultSet::getRecords
      */
     public function testFilter(): void
     {
@@ -516,4 +518,20 @@ public function testJsonSerialize(): void
             json_encode($result)
         );
     }
+
+    /**
+     * @covers ::validateHeader
+     */
+    public function testHeaderThrowsExceptionOnError(): void
+    {
+        self::expectException(SyntaxError::class);
+        $csv = Reader::createFromString(
+            'field1,field1,field3
+            1,2,3
+            4,5,6'
+        );
+        $csv->setDelimiter(',');
+        $resultSet = Statement::create()->process($csv);
+        Statement::create()->process($resultSet, ['foo', 'foo']);
+    }
 }