Adding ResultSet::createFromTabularDataReader

Author: nyamsprod

CHANGELOG.md

@@ -11,7 +11,7 @@ All Notable changes to `Csv` will be documented in this file
 - `League\Csv\Statement` can now also process `League\Csv\ResultSet` instances.
 - `League\Csv\TabularDataReader` interface to represent how to read tabular data
 - `League\Csv\ResultSet::getRecords` has an optional `$header` second argument to make the method works like `League\Csv\Reader::getRecords` 
-- `League\Csv\ResultSet::createFromReader` create a new instance from `League\Csv\Reader` 
+- `League\Csv\ResultSet::createFromTabularDataReader` create a new instance from `League\Csv\TabularDataReader` implementing class.
 
 ### Deprecated
 

src/Reader.php

@@ -199,23 +199,23 @@ protected function removeBOM(array $record, int $bom_length, string $enclosure):
      */
     public function fetchColumn($index = 0): Iterator
     {
-        return ResultSet::createFromReader($this)->fetchColumn($index);
+        return ResultSet::createFromTabularDataReader($this)->fetchColumn($index);
     }
 
     /**
      * {@inheritdoc}
      */
     public function fetchOne(int $nth_record = 0): array
     {
-        return ResultSet::createFromReader($this)->fetchOne($nth_record);
+        return ResultSet::createFromTabularDataReader($this)->fetchOne($nth_record);
     }
 
     /**
      * {@inheritdoc}
      */
     public function fetchPairs($offset_index = 0, $value_index = 1): Iterator
     {
-        return ResultSet::createFromReader($this)->fetchPairs($offset_index, $value_index);
+        return ResultSet::createFromTabularDataReader($this)->fetchPairs($offset_index, $value_index);
     }
 
     /**

src/ResultSet.php

@@ -75,7 +75,7 @@ public function __destruct()
     /**
      * Returns a new instance from a League\Csv\Reader object.
      */
-    public static function createFromReader(Reader $reader): self
+    public static function createFromTabularDataReader(Reader $reader): self
     {
         return new self($reader->getRecords(), $reader->getHeader());
     }