Skip to content

Commit 5b029ad

Browse files
committed
[NTOS:KD] Move some declarations where they belong
1 parent ebe4021 commit 5b029ad

File tree

4 files changed

+29
-44
lines changed

4 files changed

+29
-44
lines changed

ntoskrnl/include/internal/kd.h

Lines changed: 0 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -30,48 +30,6 @@ KdPortPutByteEx(
3030
/* SYMBOL ROUTINES **********************************************************/
3131
#ifdef __NTOSKRNL__
3232

33-
#if defined(KDBG) || DBG
34-
35-
#if defined(KDBG)
36-
typedef
37-
BOOLEAN
38-
(NTAPI *PKDBG_CLI_ROUTINE)(
39-
IN PCHAR Command,
40-
IN ULONG Argc,
41-
IN PCH Argv[]);
42-
43-
BOOLEAN
44-
NTAPI
45-
KdbRegisterCliCallback(
46-
PVOID Callback,
47-
BOOLEAN Deregister);
48-
#endif
49-
50-
VOID
51-
KdbSymProcessSymbols(
52-
IN PLDR_DATA_TABLE_ENTRY LdrEntry);
53-
54-
55-
BOOLEAN
56-
KdbSymPrintAddress(
57-
IN PVOID Address,
58-
IN PKTRAP_FRAME Context
59-
);
60-
61-
NTSTATUS
62-
KdbSymGetAddressInformation(
63-
IN PROSSYM_INFO RosSymInfo,
64-
IN ULONG_PTR RelativeAddress,
65-
#ifdef __ROS_DWARF__
66-
IN PROSSYM_LINEINFO RosSymLineInfo
67-
#else
68-
OUT PULONG LineNumber OPTIONAL,
69-
OUT PCH FileName OPTIONAL,
70-
OUT PCH FunctionName OPTIONAL
71-
#endif
72-
);
73-
#endif
74-
7533
#ifdef KDBG
7634
# define KdbInit() KdbpCliInit()
7735
# define KdbModuleLoaded(FILENAME) KdbpCliModuleLoaded(FILENAME)

ntoskrnl/kdbg/kdb.h

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,6 +96,12 @@ KdbpStackSwitchAndCall(
9696

9797
extern PCHAR KdbInitFileBuffer;
9898

99+
BOOLEAN
100+
NTAPI
101+
KdbRegisterCliCallback(
102+
PVOID Callback,
103+
BOOLEAN Deregister);
104+
99105
VOID
100106
KdbpCliInit(VOID);
101107

@@ -154,6 +160,12 @@ KdbpSymFindModule(
154160
IN INT Index OPTIONAL,
155161
OUT PLDR_DATA_TABLE_ENTRY* pLdrEntry);
156162

163+
BOOLEAN
164+
KdbSymPrintAddress(
165+
IN PVOID Address,
166+
IN PKTRAP_FRAME Context
167+
);
168+
157169
/* from kdb.c */
158170

159171
extern PEPROCESS KdbCurrentProcess;

ntoskrnl/kdbg/kdb_cli.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,13 @@ static BOOLEAN KdbpCmdPrintStruct(ULONG Argc, PCHAR Argv[]);
105105

106106
/* GLOBALS *******************************************************************/
107107

108+
typedef
109+
BOOLEAN
110+
(NTAPI *PKDBG_CLI_ROUTINE)(
111+
IN PCHAR Command,
112+
IN ULONG Argc,
113+
IN PCH Argv[]);
114+
108115
static PKDBG_CLI_ROUTINE KdbCliCallbacks[10];
109116
static BOOLEAN KdbUseIntelSyntax = FALSE; /* Set to TRUE for intel syntax */
110117
static BOOLEAN KdbBreakOnModuleLoad = FALSE; /* Set to TRUE to break into KDB when a module is loaded */

ntoskrnl/kdbg/kdb_symbols.c

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,14 @@ BOOLEAN KdbpSymbolsInitialized = FALSE;
3333

3434
/* FUNCTIONS ****************************************************************/
3535

36+
static NTSTATUS
37+
KdbSymGetAddressInformation(
38+
IN PROSSYM_INFO RosSymInfo,
39+
IN ULONG_PTR RelativeAddress,
40+
OUT PULONG LineNumber OPTIONAL,
41+
OUT PCH FileName OPTIONAL,
42+
OUT PCH FunctionName OPTIONAL);
43+
3644
static BOOLEAN
3745
KdbpSymSearchModuleList(
3846
IN PLIST_ENTRY current_entry,
@@ -200,7 +208,7 @@ KdbSymPrintAddress(
200208
* \retval STATUS_SUCCESS At least one of the requested informations was found.
201209
* \retval STATUS_UNSUCCESSFUL None of the requested information was found.
202210
*/
203-
NTSTATUS
211+
static NTSTATUS
204212
KdbSymGetAddressInformation(
205213
IN PROSSYM_INFO RosSymInfo,
206214
IN ULONG_PTR RelativeAddress,
@@ -420,7 +428,7 @@ KdbpSymLoadModuleSymbols(
420428
DPRINT("Installed symbols: %wZ %p\n", FileName, *RosSymInfo);
421429
}
422430

423-
VOID
431+
static VOID
424432
KdbSymProcessSymbols(
425433
IN PLDR_DATA_TABLE_ENTRY LdrEntry)
426434
{

0 commit comments

Comments
 (0)