Skip to content

Commit c2a9c48

Browse files
committed
[NtGdi]
- Remove Path for MoveTo. It is not needed. svn path=/trunk/; revision=72603
1 parent 7049508 commit c2a9c48

File tree

4 files changed

+10
-33
lines changed

4 files changed

+10
-33
lines changed

reactos/win32ss/gdi/ntgdi/arc.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -238,9 +238,9 @@ IntGdiArcInternal(
238238
if (arctype == GdiTypeArcTo)
239239
{
240240
if (dc->dclevel.flPath & DCPATH_CLOCKWISE)
241-
IntGdiMoveToEx(dc, XStartArc, YStartArc, NULL, TRUE);
241+
IntGdiMoveToEx(dc, XStartArc, YStartArc, NULL);
242242
else
243-
IntGdiMoveToEx(dc, XEndArc, YEndArc, NULL, TRUE);
243+
IntGdiMoveToEx(dc, XEndArc, YEndArc, NULL);
244244
}
245245
return Ret;
246246
}
@@ -285,7 +285,7 @@ IntGdiAngleArc( PDC pDC,
285285

286286
if (result)
287287
{
288-
IntGdiMoveToEx(pDC, x2, y2, NULL, TRUE);
288+
IntGdiMoveToEx(pDC, x2, y2, NULL);
289289
}
290290
return result;
291291
}

reactos/win32ss/gdi/ntgdi/intgdi.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,7 @@ BOOL FASTCALL
2525
IntGdiMoveToEx(DC *dc,
2626
int X,
2727
int Y,
28-
LPPOINT Point,
29-
BOOL BypassPath);
28+
LPPOINT Point);
3029

3130
BOOL FASTCALL
3231
IntGdiPolyBezier(DC *dc,

reactos/win32ss/gdi/ntgdi/line.c

Lines changed: 6 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,8 @@ BOOL FASTCALL
1919
IntGdiMoveToEx(DC *dc,
2020
int X,
2121
int Y,
22-
LPPOINT Point,
23-
BOOL BypassPath)
22+
LPPOINT Point)
2423
{
25-
BOOL PathIsOpen;
2624
PDC_ATTR pdcattr = dc->pdcattr;
2725
if ( Point )
2826
{
@@ -44,13 +42,6 @@ IntGdiMoveToEx(DC *dc,
4442
CoordLPtoDP(dc, &pdcattr->ptfxCurrent); // Update fx
4543
pdcattr->ulDirty_ &= ~(DIRTY_PTLCURRENT|DIRTY_PTFXCURRENT|DIRTY_STYLESTATE);
4644

47-
if (BypassPath) return TRUE;
48-
49-
PathIsOpen = PATH_IsPathOpen(dc->dclevel);
50-
51-
if ( PathIsOpen )
52-
return PATH_MoveTo ( dc );
53-
5445
return TRUE;
5546
}
5647

@@ -67,7 +58,7 @@ GreMoveTo( HDC hdc,
6758
EngSetLastError(ERROR_INVALID_HANDLE);
6859
return FALSE;
6960
}
70-
Ret = IntGdiMoveToEx(dc, x, y, pptOut, TRUE);
61+
Ret = IntGdiMoveToEx(dc, x, y, pptOut);
7162
DC_UnlockDc(dc);
7263
return Ret;
7364
}
@@ -108,16 +99,6 @@ IntGdiLineTo(DC *dc,
10899
if (PATH_IsPathOpen(dc->dclevel))
109100
{
110101
Ret = PATH_LineTo(dc, XEnd, YEnd);
111-
if (Ret)
112-
{
113-
// FIXME: PATH_LineTo should maybe do this? No
114-
pdcattr->ptlCurrent.x = XEnd;
115-
pdcattr->ptlCurrent.y = YEnd;
116-
pdcattr->ptfxCurrent = pdcattr->ptlCurrent;
117-
CoordLPtoDP(dc, &pdcattr->ptfxCurrent); // Update fx
118-
pdcattr->ulDirty_ &= ~(DIRTY_PTLCURRENT|DIRTY_PTFXCURRENT|DIRTY_STYLESTATE);
119-
}
120-
return Ret;
121102
}
122103
else
123104
{
@@ -257,9 +238,6 @@ IntGdiPolyline(DC *dc,
257238
return FALSE;
258239
}
259240

260-
if (PATH_IsPathOpen(dc->dclevel))
261-
return PATH_Polyline(dc, pt, Count);
262-
263241
DC_vPrepareDCsForBlit(dc, NULL, NULL, NULL);
264242
psurf = dc->dclevel.pSurface;
265243

@@ -355,8 +333,9 @@ IntGdiPolyPolyline(DC *dc,
355333
pc = PolyPoints;
356334

357335
if (PATH_IsPathOpen(dc->dclevel))
336+
{
358337
return PATH_PolyPolyline( dc, pt, PolyPoints, Count );
359-
338+
}
360339
for (i = 0; i < Count; i++)
361340
{
362341
ret = IntGdiPolyline ( dc, pts, *pc );
@@ -544,7 +523,7 @@ NtGdiPolyDraw(
544523
}
545524

546525
if (num_pts >= 2) IntGdiPolyline( dc, line_pts, num_pts );
547-
IntGdiMoveToEx( dc, line_pts[num_pts - 1].x, line_pts[num_pts - 1].y, NULL, TRUE );
526+
IntGdiMoveToEx( dc, line_pts[num_pts - 1].x, line_pts[num_pts - 1].y, NULL );
548527
result = TRUE;
549528
}
550529
_SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER)
@@ -592,7 +571,7 @@ NtGdiMoveTo(
592571
pdc = DC_LockDc(hdc);
593572
if (!pdc) return FALSE;
594573

595-
Ret = IntGdiMoveToEx(pdc, x, y, &Point, TRUE);
574+
Ret = IntGdiMoveToEx(pdc, x, y, &Point);
596575

597576
if (Ret && pptOut)
598577
{

reactos/win32ss/gdi/ntgdi/path.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ BOOL FASTCALL PATH_Arc (PDC dc, INT x1, INT y1, INT x2, INT y2, INT xStart, INT
5454
BOOL FASTCALL PATH_Ellipse (PDC dc, INT x1, INT y1, INT x2, INT y2);
5555
VOID FASTCALL PATH_EmptyPath (PPATH pPath);
5656
BOOL FASTCALL PATH_LineTo (PDC dc, INT x, INT y);
57-
BOOL FASTCALL PATH_MoveTo (PDC dc);
5857
BOOL FASTCALL PATH_PolyBezier (PDC dc, const POINT *pts, DWORD cbPoints);
5958
BOOL FASTCALL PATH_PolyBezierTo (PDC dc, const POINT *pts, DWORD cbPoints);
6059
BOOL FASTCALL PATH_PolyDraw(PDC dc, const POINT *pts, const BYTE *types, DWORD cbPoints);

0 commit comments

Comments
 (0)