Skip to content

Commit 85f8fc2

Browse files
committed
Remove alt generation from image_submit_tag
1 parent 783295f commit 85f8fc2

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

actionview/lib/action_view/helpers/form_tag_helper.rb

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -534,22 +534,22 @@ def button_tag(content_or_options = nil, options = nil, &block)
534534
#
535535
# ==== Examples
536536
# image_submit_tag("login.png")
537-
# # => <input alt="Login" src="http://github.com/assets/login.png" type="image" />
537+
# # => <input src="http://github.com/assets/login.png" type="image" />
538538
#
539539
# image_submit_tag("purchase.png", disabled: true)
540-
# # => <input alt="Purchase" disabled="disabled" src="http://github.com/assets/purchase.png" type="image" />
540+
# # => <input disabled="disabled" src="http://github.com/assets/purchase.png" type="image" />
541541
#
542542
# image_submit_tag("search.png", class: 'search_button', alt: 'Find')
543-
# # => <input alt="Find" class="search_button" src="http://github.com/assets/search.png" type="image" />
543+
# # => <input class="search_button" src="http://github.com/assets/search.png" type="image" />
544544
#
545545
# image_submit_tag("agree.png", disabled: true, class: "agree_disagree_button")
546-
# # => <input alt="Agree" class="agree_disagree_button" disabled="disabled" src="http://github.com/assets/agree.png" type="image" />
546+
# # => <input class="agree_disagree_button" disabled="disabled" src="http://github.com/assets/agree.png" type="image" />
547547
#
548548
# image_submit_tag("save.png", data: { confirm: "Are you sure?" })
549-
# # => <input alt="Save" src="http://github.com/assets/save.png" data-confirm="Are you sure?" type="image" />
549+
# # => <input src="http://github.com/assets/save.png" data-confirm="Are you sure?" type="image" />
550550
def image_submit_tag(source, options = {})
551551
options = options.stringify_keys
552-
tag :input, { "alt" => image_alt(source), "type" => "image", "src" => path_to_image(source) }.update(options)
552+
tag :input, { "type" => "image", "src" => path_to_image(source) }.update(options)
553553
end
554554

555555
# Creates a field set for grouping HTML form elements.

actionview/test/template/form_tag_helper_test.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -641,7 +641,7 @@ def test_button_tag_with_data_disable_with_option
641641

642642
def test_image_submit_tag_with_confirmation
643643
assert_dom_equal(
644-
%(<input alt="Save" type="image" src="http://github.com/images/save.gif" data-confirm="Are you sure?" />),
644+
%(<input type="image" src="http://github.com/images/save.gif" data-confirm="Are you sure?" />),
645645
image_submit_tag("save.gif", data: { confirm: "Are you sure?" })
646646
)
647647
end

0 commit comments

Comments
 (0)