Skip to content

Commit b3e6d5f

Browse files
authored
Merge pull request rails#35565 from yahonda/rm_test_create_table_with_custom_sequence_name
Remove `MigrationTest#test_create_table_with_custom_sequence_name`
2 parents 2440bef + 503c647 commit b3e6d5f

File tree

1 file changed

+0
-33
lines changed

1 file changed

+0
-33
lines changed

activerecord/test/cases/migration_test.rb

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -567,39 +567,6 @@ def test_allows_sqlite3_rollback_on_invalid_column_type
567567
end
568568
end
569569

570-
if current_adapter? :OracleAdapter
571-
def test_create_table_with_custom_sequence_name
572-
# table name is 29 chars, the standard sequence name will
573-
# be 33 chars and should be shortened
574-
assert_nothing_raised do
575-
Person.connection.create_table :table_with_name_thats_just_ok do |t|
576-
t.column :foo, :string, null: false
577-
end
578-
ensure
579-
Person.connection.drop_table :table_with_name_thats_just_ok rescue nil
580-
end
581-
582-
# should be all good w/ a custom sequence name
583-
assert_nothing_raised do
584-
Person.connection.create_table :table_with_name_thats_just_ok,
585-
sequence_name: "suitably_short_seq" do |t|
586-
t.column :foo, :string, null: false
587-
end
588-
589-
Person.connection.execute("select suitably_short_seq.nextval from dual")
590-
591-
ensure
592-
Person.connection.drop_table :table_with_name_thats_just_ok,
593-
sequence_name: "suitably_short_seq" rescue nil
594-
end
595-
596-
# confirm the custom sequence got dropped
597-
assert_raise(ActiveRecord::StatementInvalid) do
598-
Person.connection.execute("select suitably_short_seq.nextval from dual")
599-
end
600-
end
601-
end
602-
603570
def test_decimal_scale_without_precision_should_raise
604571
e = assert_raise(ArgumentError) do
605572
Person.connection.create_table :test_decimal_scales, force: true do |t|

0 commit comments

Comments
 (0)