panic on negative amount transactionlog, add addlog (iotexproject#2352)

Author: Yutong Pei

action/protocol/execution/evm/evm.go

@@ -205,7 +205,7 @@ func ExecuteContract(
 		return nil, nil, errors.Wrap(err, "failed to commit contracts to underlying db")
 	}
 	stateDB.clear()
-	receipt.Logs = stateDB.Logs()
+	receipt.AddLogs(stateDB.Logs()...)
 	log.S().Debugf("Receipt: %+v, %v", receipt, err)
 	return retval, receipt, nil
 }

action/protocol/rewarding/protocol.go

@@ -375,20 +375,14 @@ func (p *Protocol) createReceipt(
 	gasConsumed uint64,
 	logs ...*action.Log,
 ) *action.Receipt {
-	// remove possible nil log
-	nlogs := make([]*action.Log, 0, len(logs))
-	for _, l := range logs {
-		if l != nil {
-			nlogs = append(nlogs, l)
-		}
-	}
 	// TODO: need to review the fields
-	return &action.Receipt{
+	r := &action.Receipt{
 		Status:          status,
 		BlockHeight:     blkHeight,
 		ActionHash:      actHash,
 		GasConsumed:     gasConsumed,
 		ContractAddress: p.addr.String(),
-		Logs:            nlogs,
 	}
+	r.AddLogs(logs...)
+	return r
 }

action/protocol/staking/protocol.go

@@ -454,8 +454,6 @@ func (p *Protocol) settleAction(
 		GasConsumed:     actionCtx.IntrinsicGas,
 		ContractAddress: p.addr.String(),
 	}
-	if len(logs) != 0 {
-		r.Logs = logs
-	}
+	r.AddLogs(logs...)
 	return &r, nil
 }

action/receipt.go

@@ -119,6 +119,18 @@ func (receipt *Receipt) Hash() hash.Hash256 {
 	return hash.Hash256b(data)
 }
 
+// AddLogs add log to receipt and filter out nil log.
+func (receipt *Receipt) AddLogs(logs ...*Log) {
+	if receipt.Logs == nil {
+		receipt.Logs = make([]*Log, 0, len(logs))
+	}
+	for _, l := range logs {
+		if l != nil {
+			receipt.Logs = append(receipt.Logs, l)
+		}
+	}
+}
+
 // ConvertToLogPb converts a Log to protobuf's Log
 func (log *Log) ConvertToLogPb() *iotextypes.Log {
 	l := &iotextypes.Log{}

blockchain/block/systemlog.go

@@ -10,8 +10,10 @@ import (
 	"github.com/golang/protobuf/proto"
 	"github.com/iotexproject/go-pkgs/hash"
 	"github.com/iotexproject/iotex-proto/golang/iotextypes"
+	"go.uber.org/zap"
 
 	"github.com/iotexproject/iotex-core/action"
+	"github.com/iotexproject/iotex-core/pkg/log"
 	"github.com/iotexproject/iotex-core/pkg/util/byteutil"
 )
 
@@ -154,15 +156,18 @@ func ReceiptTransactionLog(r *action.Receipt) *TransactionLog {
 }
 
 // LogTokenTxRecord generates token transaction record from log
-func LogTokenTxRecord(log *action.Log) *TokenTxRecord {
-	if log == nil || !log.IsTransactionLog() {
+func LogTokenTxRecord(l *action.Log) *TokenTxRecord {
+	if l == nil || !l.IsTransactionLog() {
 		return nil
 	}
+	if l.TransactionData.Amount.Sign() < 0 {
+		log.L().Panic("Negative amount transaction log.", zap.Any("TransactionLog", l.TransactionData))
+	}
 
 	return &TokenTxRecord{
-		sender:    log.TransactionData.Sender,
-		recipient: log.TransactionData.Recipient,
-		amount:    log.TransactionData.Amount.String(),
-		typ:       log.TransactionData.Type,
+		sender:    l.TransactionData.Sender,
+		recipient: l.TransactionData.Recipient,
+		amount:    l.TransactionData.Amount.String(),
+		typ:       l.TransactionData.Type,
 	}
 }