delete candidates by height api from blockchain (iotexproject#1666)

delete productivity_by_epoch

return protocols in registry in order

introduce genesis states creator interface

introduce PreStatesCreator and PostSystemActionsCreator to protocol

fix dardanelles bug

Author: CoderZhi

action/protocol/account/protocol.go

@@ -66,17 +66,13 @@ func (p *Protocol) ReadState(context.Context, protocol.StateManager, []byte, ...
 	return nil, protocol.ErrUnimplemented
 }
 
-// Initialize initializes the protocol by setting the initial balances to some addresses
-func (p *Protocol) Initialize(
-	ctx context.Context,
-	sm protocol.StateManager,
-	addrs []address.Address,
-	amounts []*big.Int,
-) error {
+// CreateGenesisStates initializes the protocol by setting the initial balances to some addresses
+func (p *Protocol) CreateGenesisStates(ctx context.Context, sm protocol.StateManager) error {
 	raCtx := protocol.MustGetRunActionsCtx(ctx)
 	if err := p.assertZeroBlockHeight(raCtx.BlockHeight); err != nil {
 		return err
 	}
+	addrs, amounts := raCtx.Genesis.InitBalances()
 	if err := p.assertEqualLength(addrs, amounts); err != nil {
 		return err
 	}

action/protocol/account/protocol_test.go

@@ -12,11 +12,9 @@ import (
 	"testing"
 
 	"github.com/golang/mock/gomock"
-	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 
 	"github.com/iotexproject/go-pkgs/hash"
-	"github.com/iotexproject/iotex-address/address"
 	"github.com/iotexproject/iotex-core/action/protocol"
 	accountutil "github.com/iotexproject/iotex-core/action/protocol/account/util"
 	"github.com/iotexproject/iotex-core/config"
@@ -65,7 +63,7 @@ func TestLoadOrCreateAccountState(t *testing.T) {
 }
 
 func TestProtocol_Initialize(t *testing.T) {
-	p := NewProtocol()
+	require := require.New(t)
 	ctrl := gomock.NewController(t)
 	defer ctrl.Finish()
 	sm := mock_chainmanager.NewMockStateManager(ctrl)
@@ -88,28 +86,25 @@ func TestProtocol_Initialize(t *testing.T) {
 			return nil
 		}).AnyTimes()
 
+	ge := config.Default.Genesis
+	ge.Account.InitBalanceMap = map[string]string{
+		identityset.Address(0).String(): big.NewInt(100).String(),
+		identityset.Address(1).String(): big.NewInt(200).String(),
+	}
+	p := NewProtocol()
 	require.NoError(
-		t,
-		p.Initialize(
+		p.CreateGenesisStates(
 			protocol.WithRunActionsCtx(context.Background(), protocol.RunActionsCtx{
 				BlockHeight: 0,
-				Genesis:     config.Default.Genesis,
+				Genesis:     ge,
 			}),
 			sm,
-			[]address.Address{
-				identityset.Address(0),
-				identityset.Address(1),
-			},
-			[]*big.Int{
-				big.NewInt(100),
-				big.NewInt(200),
-			},
 		),
 	)
 	acc0, err := accountutil.LoadOrCreateAccount(sm, identityset.Address(0).String(), big.NewInt(0))
-	require.NoError(t, err)
-	assert.Equal(t, big.NewInt(100), acc0.Balance)
+	require.NoError(err)
+	require.Equal(big.NewInt(100), acc0.Balance)
 	acc1, err := accountutil.LoadOrCreateAccount(sm, identityset.Address(1).String(), big.NewInt(0))
-	require.NoError(t, err)
-	assert.Equal(t, big.NewInt(200), acc1.Balance)
+	require.NoError(err)
+	require.Equal(big.NewInt(200), acc1.Balance)
 }

action/protocol/account/transfer.go

@@ -120,6 +120,7 @@ func (p *Protocol) handleTransfer(ctx context.Context, act action.Action, sm pro
 			return nil, err
 		}
 	}
+
 	return &action.Receipt{
 		Status:          uint64(iotextypes.ReceiptStatus_Success),
 		BlockHeight:     raCtx.BlockHeight,

action/protocol/account/transfer_test.go

@@ -39,7 +39,6 @@ func TestProtocol_HandleTransfer(t *testing.T) {
 	cfg := config.Default
 	ctx := context.Background()
 	sm := mock_chainmanager.NewMockStateManager(ctrl)
-	cm := mock_chainmanager.NewMockChainManager(ctrl)
 	cb := db.NewCachedBatch()
 	sm.EXPECT().State(gomock.Any(), gomock.Any()).DoAndReturn(
 		func(addrHash hash.Hash160, account interface{}) error {
@@ -60,30 +59,30 @@ func TestProtocol_HandleTransfer(t *testing.T) {
 		}).AnyTimes()
 
 	p := NewProtocol()
-	reward := rewarding.NewProtocol(cm, rolldpos.NewProtocol(1, 1, 1))
-	registry := protocol.Registry{}
+	reward := rewarding.NewProtocol(nil, rolldpos.NewProtocol(1, 1, 1))
+	registry := protocol.NewRegistry()
 	require.NoError(registry.Register(rewarding.ProtocolID, reward))
+	cfg.Genesis.Rewarding.InitBalanceStr = "0"
+	cfg.Genesis.Rewarding.BlockRewardStr = "0"
+	cfg.Genesis.Rewarding.EpochRewardStr = "0"
+	cfg.Genesis.Rewarding.NumDelegatesForEpochReward = 1
+	cfg.Genesis.Rewarding.ExemptAddrStrsFromEpochReward = []string{}
+	cfg.Genesis.Rewarding.FoundationBonusStr = "0"
+	cfg.Genesis.Rewarding.NumDelegatesForFoundationBonus = 0
+	cfg.Genesis.Rewarding.FoundationBonusLastEpoch = 0
+	cfg.Genesis.Rewarding.ProductivityThreshold = 0
 	require.NoError(
-		reward.Initialize(
+		reward.CreateGenesisStates(
 			protocol.WithRunActionsCtx(context.Background(),
 				protocol.RunActionsCtx{
 					BlockHeight: 0,
 					Producer:    identityset.Address(27),
 					Caller:      identityset.Address(28),
 					GasLimit:    testutil.TestGasLimit,
-					Registry:    &registry,
+					Registry:    registry,
 					Genesis:     cfg.Genesis,
 				}),
 			sm,
-			big.NewInt(0),
-			big.NewInt(0),
-			big.NewInt(0),
-			1,
-			nil,
-			big.NewInt(0),
-			0,
-			0,
-			0,
 		),
 	)
 
@@ -118,7 +117,7 @@ func TestProtocol_HandleTransfer(t *testing.T) {
 			Caller:       identityset.Address(28),
 			GasLimit:     testutil.TestGasLimit,
 			IntrinsicGas: gas,
-			Registry:     &registry,
+			Registry:     registry,
 		})
 	receipt, err := p.Handle(ctx, transfer, sm)
 	require.NoError(err)

action/protocol/account/util/util.go

@@ -39,6 +39,7 @@ func LoadOrCreateAccount(sm protocol.StateManager, encodedAddr string, init *big
 	addrHash := hash.BytesToHash160(addr.Bytes())
 	err = sm.State(addrHash, &account)
 	if err == nil {
+		// TODO: init value cannot be non-zero
 		return &account, nil
 	}
 	if errors.Cause(err) == state.ErrStateNotExist {

action/protocol/context.go

@@ -15,6 +15,7 @@ import (
 	"github.com/iotexproject/iotex-address/address"
 	"github.com/iotexproject/iotex-core/blockchain/genesis"
 	"github.com/iotexproject/iotex-core/pkg/log"
+	"github.com/iotexproject/iotex-core/state"
 )
 
 type runActionsCtxKey struct{}
@@ -48,6 +49,9 @@ type RunActionsCtx struct {
 	// History indicates whether to save account/contract history or not
 	History bool
 	// Registry is the pointer of protocol registry
+	// Candidates is a list of candidates of current round
+	Candidates []*state.Candidate
+	// Registry is the pointer protocol registry
 	Registry *Registry
 }
 

action/protocol/execution/protocol_test.go

@@ -281,7 +281,7 @@ func (sct *SmartContractTest) prepareBlockchain(
 	if sct.InitGenesis.IsBering {
 		cfg.Genesis.Blockchain.BeringBlockHeight = 0
 	}
-	registry := protocol.Registry{}
+	registry := protocol.NewRegistry()
 	acc := account.NewProtocol()
 	r.NoError(registry.Register(account.ProtocolID, acc))
 	rp := rolldpos.NewProtocol(cfg.Genesis.NumCandidateDelegates, cfg.Genesis.NumDelegates, cfg.Genesis.NumSubEpochs)
@@ -296,9 +296,9 @@ func (sct *SmartContractTest) prepareBlockchain(
 		cfg,
 		dao,
 		blockchain.InMemStateFactoryOption(),
-		blockchain.RegistryOption(&registry),
+		blockchain.RegistryOption(registry),
 	)
-	reward := rewarding.NewProtocol(bc, rp)
+	reward := rewarding.NewProtocol(nil, rp)
 	r.NoError(registry.Register(rewarding.ProtocolID, reward))
 
 	r.NotNil(bc)
@@ -319,7 +319,7 @@ func (sct *SmartContractTest) prepareBlockchain(
 			Producer: identityset.Address(27),
 			GasLimit: uint64(10000000),
 			Genesis:  cfg.Genesis,
-			Registry: &registry,
+			Registry: registry,
 		})
 	_, err = ws.RunActions(ctx, 0, nil)
 	r.NoError(err)
@@ -465,7 +465,7 @@ func TestProtocol_Handle(t *testing.T) {
 		cfg.Chain.IndexDBPath = testIndexPath
 		cfg.Chain.EnableAsyncIndexWrite = false
 		cfg.Genesis.EnableGravityChainVoting = false
-		registry := protocol.Registry{}
+		registry := protocol.NewRegistry()
 		acc := account.NewProtocol()
 		require.NoError(registry.Register(account.ProtocolID, acc))
 		rp := rolldpos.NewProtocol(cfg.Genesis.NumCandidateDelegates, cfg.Genesis.NumDelegates, cfg.Genesis.NumSubEpochs)
@@ -482,7 +482,7 @@ func TestProtocol_Handle(t *testing.T) {
 			cfg,
 			dao,
 			blockchain.DefaultStateFactoryOption(),
-			blockchain.RegistryOption(&registry),
+			blockchain.RegistryOption(registry),
 		)
 		exeProtocol := NewProtocol(bc.BlockDAO().GetBlockHash)
 		require.NoError(registry.Register(ProtocolID, exeProtocol))
@@ -506,7 +506,7 @@ func TestProtocol_Handle(t *testing.T) {
 				Producer: identityset.Address(27),
 				GasLimit: gasLimit,
 				Genesis:  cfg.Genesis,
-				Registry: &registry,
+				Registry: registry,
 			})
 		_, err = ws.RunActions(ctx, 0, nil)
 		require.NoError(err)

action/protocol/mock_protocol_test.go

@@ -131,6 +131,7 @@ func (ns *NativeStaking) readBuckets(prevIndx, limit *big.Int, height uint64, ts
 	if len(pygg.CanNames) == 0 {
 		return nil, ErrEndOfData
 	}
+
 	buckets := make([]*types.Bucket, len(pygg.CanNames))
 	for i := range pygg.CanNames {
 		buckets[i], err = types.NewBucket(