Skip to content

Commit 6afc38e

Browse files
Tranceversatya164
authored andcommitted
fix: fix issue with sibling components being clipped. fixes callstack#527
1 parent abb71cb commit 6afc38e

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

src/components/Portal/PortalManager.js

+8-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,14 @@ export default class PortalManager extends React.PureComponent<{}, State> {
4141

4242
render() {
4343
return this.state.portals.map(({ key, children }) => (
44-
<View key={key} pointerEvents="box-none" style={StyleSheet.absoluteFill}>
44+
<View
45+
key={key}
46+
collapsable={
47+
false /* Need collapsable=false here to clip the elevations, otherwise they appear above sibling components */
48+
}
49+
pointerEvents="box-none"
50+
style={StyleSheet.absoluteFill}
51+
>
4552
{children}
4653
</View>
4754
));

src/components/__tests__/__snapshots__/Portal.test.js.snap

+1
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ Array [
1919
</Text>
2020
</View>,
2121
<View
22+
collapsable={false}
2223
pointerEvents="box-none"
2324
style={
2425
Object {

0 commit comments

Comments
 (0)