Escape double quotes per RFC 4180

justinethier · justinethier · commit b0cf0b402779 · 2013-07-31T15:54:28.000-04:00
According to this RFC:

      7.  If double-quotes are used to enclose fields, then a double-quote
          appearing inside a field must be escaped by preceding it with
          another double quote.
diff --git a/application/libraries/Format.php b/application/libraries/Format.php
@@ -200,6 +200,7 @@ public function to_csv()
 		$output = implode(',', $headings).PHP_EOL;
 		foreach ($data as &$row)
 		{
+			$row = str_replace('"', '""', $row); // Escape dbl quotes per RFC 4180
 			$output .= '"'.implode('","', $row).'"'.PHP_EOL;
 		}
 
@@ -267,4 +268,4 @@ private function _from_serialize($string)
 
 }
 
-/* End of file format.php */
+/* End of file format.php */

Original file line number	Diff line number	Diff line change
`@@ -200,6 +200,7 @@ public function to_csv()`
`200`	`200`	`$output = implode(',', $headings).PHP_EOL;`
`201`	`201`	`foreach ($data as &$row)`
`202`	`202`	`{`
	`203`	`+ $row = str_replace('"', '""', $row); // Escape dbl quotes per RFC 4180`
`203`	`204`	`$output .= '"'.implode('","', $row).'"'.PHP_EOL;`
`204`	`205`	`}`
`205`	`206`
`@@ -267,4 +268,4 @@ private function _from_serialize($string)`
`267`	`268`
`268`	`269`	`}`
`269`	`270`
`270`		`-/* End of file format.php */`
	`271`	`+/* End of file format.php */`