Remove 2 occurrences of 'varset("$hp", fdProcessInfo->hProcess)', one of which was being called with the initial handle from CreateProcess(). cbCreateProcess is now the only place where this variable is set, for both types of debug sessions (attaching or creating)

Mattiwatti · mrexodia · commit 2f3f28746dc3 · 2017-11-28T17:29:50.000+01:00
diff --git a/src/dbg/debugger.cpp b/src/dbg/debugger.cpp
@@ -1990,7 +1990,6 @@ static void cbAttachDebugger()
         cmddirectexec(StringUtils::sprintf("resumethread %p", tidToResume).c_str());
         tidToResume = 0;
     }
-    varset("$hp", (duint)fdProcessInfo->hProcess, true);
     varset("$pid", fdProcessInfo->dwProcessId, true);
 }
 
@@ -2662,7 +2661,6 @@ static void debugLoopFunction(void* lpParameter, bool attach)
         }
 
         //set script variables
-        varset("$hp", (duint)fdProcessInfo->hProcess, true);
         varset("$pid", fdProcessInfo->dwProcessId, true);
 
         if(!OpenProcessToken(fdProcessInfo->hProcess, TOKEN_ALL_ACCESS, &hProcessToken))

Original file line number	Diff line number	Diff line change
`@@ -1990,7 +1990,6 @@ static void cbAttachDebugger()`
`1990`	`1990`	`cmddirectexec(StringUtils::sprintf("resumethread %p", tidToResume).c_str());`
`1991`	`1991`	`tidToResume = 0;`
`1992`	`1992`	`}`
`1993`		`- varset("$hp", (duint)fdProcessInfo->hProcess, true);`
`1994`	`1993`	`varset("$pid", fdProcessInfo->dwProcessId, true);`
`1995`	`1994`	`}`
`1996`	`1995`
`@@ -2662,7 +2661,6 @@ static void debugLoopFunction(void* lpParameter, bool attach)`
`2662`	`2661`	`}`
`2663`	`2662`
`2664`	`2663`	`//set script variables`
`2665`		`- varset("$hp", (duint)fdProcessInfo->hProcess, true);`
`2666`	`2664`	`varset("$pid", fdProcessInfo->dwProcessId, true);`
`2667`	`2665`
`2668`	`2666`	`if(!OpenProcessToken(fdProcessInfo->hProcess, TOKEN_ALL_ACCESS, &hProcessToken))`