Skip to content

Commit fdeffb5

Browse files
committed
GUI: separate icon for dump + added some menu options in MainWindow
1 parent ab1cf7b commit fdeffb5

File tree

10 files changed

+59
-3
lines changed

10 files changed

+59
-3
lines changed

src/gui/Src/Gui/CPUDisassembly.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,7 @@ void CPUDisassembly::setupRightClickContextMenu()
303303
return true;
304304
});
305305

306-
mMenuBuilder->addMenu(makeMenu(QIcon(":/icons/images/memory-map.png"), tr("&Follow in Dump")), [this](QMenu * menu)
306+
mMenuBuilder->addMenu(makeMenu(QIcon(":/icons/images/dump.png"), tr("&Follow in Dump")), [this](QMenu * menu)
307307
{
308308
setupFollowReferenceMenu(rvaToVa(getInitialSelection()), menu, false, false);
309309
return true;

src/gui/Src/Gui/CPUMultiDump.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ CPUMultiDump::CPUMultiDump(CPUDisassembly* disas, int nbCpuDumpTabs, QWidget* pa
1414
{
1515
CPUDump* cpuDump = new CPUDump(disas, this);
1616
connect(cpuDump, SIGNAL(displayReferencesWidget()), this, SLOT(displayReferencesWidgetSlot()));
17-
this->addTabEx(cpuDump, QIcon(":/images/memory-map.png"), tr("Dump ") + QString::number(i + 1), QString("Dump ") + QString::number(i + 1));
17+
this->addTabEx(cpuDump, QIcon(":/icons/images/dump.png"), tr("Dump ") + QString::number(i + 1), QString("Dump ") + QString::number(i + 1));
1818
}
1919

2020
mCurrentCPUDump = (CPUDump*)currentWidget();

src/gui/Src/Gui/CPUStack.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ void CPUStack::setupContextMenu()
248248

249249
//Follow in Dump
250250
auto followDumpName = ArchValue(tr("Follow DWORD in &Dump"), tr("Follow QWORD in &Dump"));
251-
mFollowDump = new QAction(QIcon(":/icons/images/memory-map.png"), followDumpName, this);
251+
mFollowDump = new QAction(QIcon(":/icons/images/dump.png"), followDumpName, this);
252252
connect(mFollowDump, SIGNAL(triggered()), this, SLOT(followDumpSlot()));
253253

254254
auto followDumpMenuName = ArchValue(tr("&Follow DWORD in Dump"), tr("&Follow QWORD in Dump"));

src/gui/Src/Gui/HandlesView.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
HandlesView::HandlesView(QWidget* parent) : QWidget(parent)
66
{
77
mHandlesTable = new StdTable(this);
8+
mHandlesTable->setDrawDebugOnly(true);
89
int wCharWidth = mHandlesTable->getCharWidth();
910
mHandlesTable->setContextMenuPolicy(Qt::CustomContextMenu);
1011
mHandlesTable->addColumnAt(8 + 16 * wCharWidth, tr("Type"), false);
@@ -14,12 +15,14 @@ HandlesView::HandlesView(QWidget* parent) : QWidget(parent)
1415
mHandlesTable->addColumnAt(8 + wCharWidth * 20, tr("Name"), false);
1516

1617
mTcpConnectionsTable = new StdTable(this);
18+
mTcpConnectionsTable->setDrawDebugOnly(true);
1719
mTcpConnectionsTable->setContextMenuPolicy(Qt::CustomContextMenu);
1820
mTcpConnectionsTable->addColumnAt(8 + 64 * wCharWidth, tr("Remote address"), false);
1921
mTcpConnectionsTable->addColumnAt(8 + 64 * wCharWidth, tr("Local address"), false);
2022
mTcpConnectionsTable->addColumnAt(8 + 8 * wCharWidth, tr("State", "TcpConnection"), false);
2123

2224
mPrivilegesTable = new StdTable(this);
25+
mPrivilegesTable->setDrawDebugOnly(true);
2326
mPrivilegesTable->setContextMenuPolicy(Qt::CustomContextMenu);
2427
mPrivilegesTable->addColumnAt(8 + 32 * wCharWidth, tr("Privilege"), false);
2528
mPrivilegesTable->addColumnAt(8 + 16 * wCharWidth, tr("State", "Privilege"), false);

src/gui/Src/Gui/MainWindow.cpp

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -266,6 +266,9 @@ MainWindow::MainWindow(QWidget* parent)
266266
connect(ui->actionDetach, SIGNAL(triggered()), this, SLOT(detach()));
267267
connect(ui->actionChangeCommandLine, SIGNAL(triggered()), this, SLOT(changeCommandLine()));
268268
connect(ui->actionManual, SIGNAL(triggered()), this, SLOT(displayManual()));
269+
connect(ui->actionNotes, SIGNAL(triggered()), this, SLOT(displayNotesWidget()));
270+
connect(ui->actionSnowman, SIGNAL(triggered()), this, SLOT(displaySnowmanWidget()));
271+
connect(ui->actionHandles, SIGNAL(triggered()), this, SLOT(displayHandlesWidget()));
269272

270273
connect(mCpuWidget->getDisasmWidget(), SIGNAL(updateWindowTitle(QString)), this, SLOT(updateWindowTitleSlot(QString)));
271274
connect(mCpuWidget->getDisasmWidget(), SIGNAL(displayReferencesWidget()), this, SLOT(displayReferencesWidget()));
@@ -420,6 +423,7 @@ void MainWindow::refreshShortcuts()
420423
setGlobalShortcut(ui->actionBreakpoints, ConfigShortcut("ViewBreakpoints"));
421424
setGlobalShortcut(ui->actionMemoryMap, ConfigShortcut("ViewMemoryMap"));
422425
setGlobalShortcut(ui->actionCallStack, ConfigShortcut("ViewCallStack"));
426+
setGlobalShortcut(ui->actionSEHChain, ConfigShortcut("ViewSEHChain"));
423427
setGlobalShortcut(ui->actionScript, ConfigShortcut("ViewScript"));
424428
setGlobalShortcut(ui->actionSymbolInfo, ConfigShortcut("ViewSymbolInfo"));
425429
setGlobalShortcut(ui->actionSource, ConfigShortcut("ViewSource"));
@@ -430,6 +434,8 @@ void MainWindow::refreshShortcuts()
430434
setGlobalShortcut(ui->actionLabels, ConfigShortcut("ViewLabels"));
431435
setGlobalShortcut(ui->actionBookmarks, ConfigShortcut("ViewBookmarks"));
432436
setGlobalShortcut(ui->actionFunctions, ConfigShortcut("ViewFunctions"));
437+
setGlobalShortcut(ui->actionSnowman, ConfigShortcut("ViewSnowman"));
438+
setGlobalShortcut(ui->actionHandles, ConfigShortcut("ViewHandles"));
433439

434440
setGlobalShortcut(ui->actionRun, ConfigShortcut("DebugRun"));
435441
setGlobalShortcut(ui->actioneRun, ConfigShortcut("DebugeRun"));
@@ -1294,3 +1300,13 @@ void MainWindow::on_actionReloadStylesheet_triggered()
12941300
ensurePolished();
12951301
update();
12961302
}
1303+
1304+
void MainWindow::displayNotesWidget()
1305+
{
1306+
showQWidgetTab(mNotesManager);
1307+
}
1308+
1309+
void MainWindow::displayHandlesWidget()
1310+
{
1311+
showQWidgetTab(mHandlesView);
1312+
}

src/gui/Src/Gui/MainWindow.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,8 @@ public slots:
126126
void tabMovedSlot(int from, int to);
127127
void chkSaveloadTabSavedOrderStateChangedSlot(bool state);
128128
void dbgStateChangedSlot(DBGSTATE state);
129+
void displayNotesWidget();
130+
void displayHandlesWidget();
129131

130132
private:
131133
Ui::MainWindow* ui;

src/gui/Src/Gui/MainWindow.ui

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@
5353
</property>
5454
<addaction name="actionCpu"/>
5555
<addaction name="actionLog"/>
56+
<addaction name="actionNotes"/>
5657
<addaction name="actionBreakpoints"/>
5758
<addaction name="actionMemoryMap"/>
5859
<addaction name="actionCallStack"/>
@@ -67,6 +68,8 @@
6768
<addaction name="actionLabels"/>
6869
<addaction name="actionBookmarks"/>
6970
<addaction name="actionFunctions"/>
71+
<addaction name="actionSnowman"/>
72+
<addaction name="actionHandles"/>
7073
</widget>
7174
<widget class="QMenu" name="menuDebug">
7275
<property name="title">
@@ -735,6 +738,33 @@
735738
<string>Reload style.css</string>
736739
</property>
737740
</action>
741+
<action name="actionNotes">
742+
<property name="icon">
743+
<iconset resource="../../resource.qrc">
744+
<normaloff>:/icons/images/notes.png</normaloff>:/icons/images/notes.png</iconset>
745+
</property>
746+
<property name="text">
747+
<string>Notes</string>
748+
</property>
749+
</action>
750+
<action name="actionSnowman">
751+
<property name="icon">
752+
<iconset resource="../../resource.qrc">
753+
<normaloff>:/icons/images/snowman.png</normaloff>:/icons/images/snowman.png</iconset>
754+
</property>
755+
<property name="text">
756+
<string>Snowman</string>
757+
</property>
758+
</action>
759+
<action name="actionHandles">
760+
<property name="icon">
761+
<iconset resource="../../resource.qrc">
762+
<normaloff>:/icons/images/handles.png</normaloff>:/icons/images/handles.png</iconset>
763+
</property>
764+
<property name="text">
765+
<string>Handles</string>
766+
</property>
767+
</action>
738768
</widget>
739769
<layoutdefault spacing="6" margin="11"/>
740770
<resources>

src/gui/Src/Utils/Configuration.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -231,6 +231,8 @@ Configuration::Configuration() : QObject(), noMoreMsgbox(false)
231231
defaultShortcuts.insert("ViewBreakpoints", Shortcut(tr("View -> Breakpoints"), "Alt+B", true));
232232
defaultShortcuts.insert("ViewMemoryMap", Shortcut(tr("View -> Memory Map"), "Alt+M", true));
233233
defaultShortcuts.insert("ViewCallStack", Shortcut(tr("View -> Call Stack"), "Alt+K", true));
234+
defaultShortcuts.insert("ViewNotes", Shortcut(tr("View -> Notes"), "", true));
235+
defaultShortcuts.insert("ViewSEHChain", Shortcut(tr("View -> SEH"), "", true));
234236
defaultShortcuts.insert("ViewScript", Shortcut(tr("View -> Script"), "Alt+S", true));
235237
defaultShortcuts.insert("ViewSymbolInfo", Shortcut(tr("View -> Symbol Info"), "Ctrl+Alt+S", true));
236238
defaultShortcuts.insert("ViewSource", Shortcut(tr("View -> Source"), "Ctrl+Shift+S", true));
@@ -241,6 +243,8 @@ Configuration::Configuration() : QObject(), noMoreMsgbox(false)
241243
defaultShortcuts.insert("ViewLabels", Shortcut(tr("View -> Labels"), "Ctrl+Alt+L", true));
242244
defaultShortcuts.insert("ViewBookmarks", Shortcut(tr("View -> Bookmarks"), "Ctrl+Alt+B", true));
243245
defaultShortcuts.insert("ViewFunctions", Shortcut(tr("View -> Functions"), "Alt+F", true));
246+
defaultShortcuts.insert("ViewSnowman", Shortcut(tr("View -> Snowman"), "", true));
247+
defaultShortcuts.insert("ViewHandles", Shortcut(tr("View -> Handles"), "", true));
244248

245249
defaultShortcuts.insert("DebugRun", Shortcut(tr("Debug -> Run"), "F9", true));
246250
defaultShortcuts.insert("DebugeRun", Shortcut(tr("Debug -> Run (skip exceptions)"), "Shift+F9", true));

src/gui/images/dump.png

713 Bytes
Loading

src/gui/resource.qrc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,5 +95,6 @@
9595
<file>images/helpbrief.png</file>
9696
<file>images/helpmnemonic.png</file>
9797
<file>images/handles.png</file>
98+
<file>images/dump.png</file>
9899
</qresource>
99100
</RCC>

0 commit comments

Comments
 (0)