Skip to content

Commit f97a9b6

Browse files
pulakdpiamareebjamal
authored andcommitted
fix: Undo button not updating bookmark icon (fossasia#2365)
* fix fossasia#2363: Fix undo button not updating bookmark icon * fix fossasia#2363: Add TODO * fix fossasia#2363: Move TODO * fix fossasia#2363: Move TODO inside onResume * fix fossasia#2363: Add another TODO
1 parent 5212544 commit f97a9b6

File tree

1 file changed

+20
-4
lines changed

1 file changed

+20
-4
lines changed

android/app/src/main/java/org/fossasia/openevent/core/speaker/SpeakerDetailsActivity.java

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434

3535
import org.fossasia.openevent.R;
3636
import org.fossasia.openevent.common.api.Urls;
37+
import org.fossasia.openevent.common.events.BookmarkChangedEvent;
3738
import org.fossasia.openevent.common.events.ConnectionCheckEvent;
3839
import org.fossasia.openevent.common.ui.SnackbarUtil;
3940
import org.fossasia.openevent.common.ui.Views;
@@ -54,6 +55,7 @@
5455

5556
import butterknife.BindView;
5657
import butterknife.OnClick;
58+
import timber.log.Timber;
5759

5860
public class SpeakerDetailsActivity extends BaseActivity implements AppBarLayout.OnOffsetChangedListener, OnBookmarkSelectedListener, SessionsListAdapter.OnItemClickListener {
5961

@@ -286,6 +288,22 @@ private void hideEmptyURLButtons() {
286288
}
287289

288290
}
291+
292+
private void loadData() {
293+
speakerDetailsViewModel.getSpeaker(speakerName).observe(this, speakerData -> {
294+
selectedSpeaker = speakerData;
295+
loadSpeakerDetails();
296+
});
297+
}
298+
299+
//TODO: High Priority: Remove event bus pattern
300+
@Subscribe
301+
public void onBookmarksChanged(BookmarkChangedEvent bookmarkChangedEvent) {
302+
Timber.d("Bookmarks Changed");
303+
loadData();
304+
}
305+
306+
289307
@Override
290308
protected void onResume() {
291309
super.onResume();
@@ -298,10 +316,8 @@ protected void onResume() {
298316

299317
gridLayoutManager.setSpanCount(spanCount);
300318

301-
speakerDetailsViewModel.getSpeaker(speakerName).observe(this, speakerData -> {
302-
selectedSpeaker = speakerData;
303-
loadSpeakerDetails();
304-
});
319+
//TODO: Workaround. Needs fix during implementation of RealmLiveData
320+
loadData();
305321
}
306322

307323
@Override

0 commit comments

Comments
 (0)