Commit 9264cef
fix($compile): do not use
Currently, custom annotations are copied from the CDO onto the controller constructor.
Using `noop()` when no controller has been specified, pollutes it with custom annotations and
makes one component's annotations available to all other components that have `noop()` as their
controller.
Fixes angular#14391
Closes angular#14402noop() as controller for multiple components1 parent a0b5e1a commit 9264cef
2 files changed
+23
-3
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1092 | 1092 | | |
1093 | 1093 | | |
1094 | 1094 | | |
1095 | | - | |
| 1095 | + | |
1096 | 1096 | | |
1097 | 1097 | | |
1098 | 1098 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10538 | 10538 | | |
10539 | 10539 | | |
10540 | 10540 | | |
10541 | | - | |
| 10541 | + | |
10542 | 10542 | | |
10543 | 10543 | | |
10544 | 10544 | | |
| |||
10554 | 10554 | | |
10555 | 10555 | | |
10556 | 10556 | | |
10557 | | - | |
| 10557 | + | |
10558 | 10558 | | |
10559 | 10559 | | |
10560 | 10560 | | |
| |||
10566 | 10566 | | |
10567 | 10567 | | |
10568 | 10568 | | |
| 10569 | + | |
| 10570 | + | |
| 10571 | + | |
| 10572 | + | |
| 10573 | + | |
| 10574 | + | |
| 10575 | + | |
| 10576 | + | |
| 10577 | + | |
| 10578 | + | |
| 10579 | + | |
| 10580 | + | |
| 10581 | + | |
| 10582 | + | |
| 10583 | + | |
| 10584 | + | |
| 10585 | + | |
| 10586 | + | |
| 10587 | + | |
| 10588 | + | |
10569 | 10589 | | |
10570 | 10590 | | |
10571 | 10591 | | |
| |||
0 commit comments