Merge pull request iluwatar#359 from DevFactory/release/Local-Variables-should-not-be-declared-and-then-immediately-returned-or-thrown-fix-1

squid:S1488 - Local Variables should not be declared and then immedia…

Author: iluwatar

caching/src/main/java/com/iluwatar/caching/DbManager.java

@@ -72,9 +72,7 @@ public static UserAccount readFromDb(String userId) {
       return null;
     }
     Document doc = iterable.first();
-    UserAccount userAccount =
-        new UserAccount(userId, doc.getString("userName"), doc.getString("additionalInfo"));
-    return userAccount;
+    return new UserAccount(userId, doc.getString("userName"), doc.getString("additionalInfo"));
   }
 
   /**

dao/src/main/java/com/iluwatar/dao/Customer.java

@@ -66,7 +66,6 @@ public boolean equals(final Object o) {
 
   @Override
   public int hashCode() {
-    int result = getId();
-    return result;
+    return getId();
   }
 }

fluentinterface/src/main/java/com/iluwatar/fluentinterface/fluentiterable/lazy/LazyFluentIterable.java

@@ -204,8 +204,7 @@ public NEW_TYPE computeNext() {
    */
   @Override
   public List<TYPE> asList() {
-    List<TYPE> copy = FluentIterable.copyToList(iterable);
-    return copy;
+    return FluentIterable.copyToList(iterable);
   }
 
   @Override

naked-objects/webapp/src/main/java/domainapp/webapp/SimpleApplication.java

@@ -118,8 +118,7 @@ public WebRequest newWebRequest(HttpServletRequest servletRequest, String filter
     } catch (Exception e) {
       System.out.println(e);
     }
-    WebRequest request = super.newWebRequest(servletRequest, filterPath);
-    return request;
+    return super.newWebRequest(servletRequest, filterPath);
   }
 
   @Override
@@ -150,8 +149,7 @@ private static String readLines(final Class<?> contextClass, final String resour
       List<String> readLines =
           Resources.readLines(Resources.getResource(contextClass, resourceName),
               Charset.defaultCharset());
-      final String aboutText = Joiner.on("\n").join(readLines);
-      return aboutText;
+      return Joiner.on("\n").join(readLines);
     } catch (IOException e) {
       return "This is a simple app";
     }