Skip to content

Commit 1af3b72

Browse files
committed
Revert changes to SimpleAHC because clirr does not allow addition of interface methods
This reverts commit 5514a80.
1 parent 5514a80 commit 1af3b72

File tree

2 files changed

+3
-371
lines changed

2 files changed

+3
-371
lines changed

src/main/java/com/ning/http/client/SimpleAsyncHttpClient.java

Lines changed: 3 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -70,18 +70,15 @@ public class SimpleAsyncHttpClient {
7070
private final ErrorDocumentBehaviour errorDocumentBehaviour;
7171
private final SimpleAHCTransferListener listener;
7272
private final boolean derived;
73-
private Realm realm;
7473

75-
private SimpleAsyncHttpClient(AsyncHttpClientConfig config, Realm realm, RequestBuilder requestBuilder, ThrowableHandler defaultThrowableHandler,
76-
ErrorDocumentBehaviour errorDocumentBehaviour, boolean resumeEnabled, AsyncHttpClient ahc, SimpleAHCTransferListener listener) {
74+
private SimpleAsyncHttpClient(AsyncHttpClientConfig config, RequestBuilder requestBuilder, ThrowableHandler defaultThrowableHandler, ErrorDocumentBehaviour errorDocumentBehaviour, boolean resumeEnabled, AsyncHttpClient ahc, SimpleAHCTransferListener listener) {
7775
this.config = config;
7876
this.requestBuilder = requestBuilder;
7977
this.defaultThrowableHandler = defaultThrowableHandler;
8078
this.resumeEnabled = resumeEnabled;
8179
this.errorDocumentBehaviour = errorDocumentBehaviour;
8280
this.asyncHttpClient = ahc;
8381
this.listener = listener;
84-
this.realm = realm;
8582

8683
this.derived = ahc != null;
8784
}
@@ -274,8 +271,6 @@ private Future<Response> execute(RequestBuilder rb, BodyConsumer bodyConsumer, T
274271
throwableHandler = defaultThrowableHandler;
275272
}
276273

277-
rb.setRealm(realm);
278-
279274
Request request = rb.build();
280275
ProgressAsyncHandler<Response> handler = new BodyConsumerAsyncHandler(bodyConsumer, throwableHandler, errorDocumentBehaviour, request.getUrl(), listener);
281276

@@ -388,20 +383,6 @@ public interface DerivedBuilder {
388383

389384
DerivedBuilder setResumableDownload(boolean resume);
390385

391-
DerivedBuilder setRealmEnconding(String enc);
392-
393-
DerivedBuilder setRealmUsePreemptiveAuth(boolean usePreemptiveAuth);
394-
395-
DerivedBuilder setRealmName(String realmName);
396-
397-
DerivedBuilder setRealmScheme(Realm.AuthScheme scheme);
398-
399-
DerivedBuilder setRealmPassword(String password);
400-
401-
DerivedBuilder setRealmPrincipal(String principal);
402-
403-
DerivedBuilder setRealmDomain(String domain);
404-
405386
SimpleAsyncHttpClient build();
406387
}
407388

@@ -432,10 +413,6 @@ private Builder(SimpleAsyncHttpClient client) {
432413
this.enableResumableDownload = client.resumeEnabled;
433414
this.ahc = client.asyncHttpClient();
434415
this.listener = client.listener;
435-
436-
if (client.realm != null) {
437-
realm().clone(client.realm);
438-
}
439416
}
440417

441418
public Builder addBodyPart(Part part) throws IllegalArgumentException {
@@ -684,10 +661,8 @@ public Builder setMaxRequestRetry(int maxRequestRetry) {
684661

685662
public SimpleAsyncHttpClient build() {
686663

687-
Realm realm = null;
688664
if (realmBuilder != null) {
689-
realm = realmBuilder.build();
690-
configBuilder.setRealm(realm);
665+
configBuilder.setRealm(realmBuilder.build());
691666
}
692667

693668
if (proxyHost != null) {
@@ -696,8 +671,7 @@ public SimpleAsyncHttpClient build() {
696671

697672
configBuilder.addIOExceptionFilter(new ResumableIOExceptionFilter());
698673

699-
SimpleAsyncHttpClient sc = new SimpleAsyncHttpClient(configBuilder.build(), realm, requestBuilder, defaultThrowableHandler,
700-
errorDocumentBehaviour, enableResumableDownload, ahc, listener);
674+
SimpleAsyncHttpClient sc = new SimpleAsyncHttpClient(configBuilder.build(), requestBuilder, defaultThrowableHandler, errorDocumentBehaviour, enableResumableDownload, ahc, listener);
701675

702676
return sc;
703677
}

0 commit comments

Comments
 (0)