Improve error logging

jfarcand · jfarcand · commit 9350debf5774 · 2011-05-27T15:18:34.000-04:00
diff --git a/src/main/java/com/ning/http/client/providers/netty/NettyConnectionsPool.java b/src/main/java/com/ning/http/client/providers/netty/NettyConnectionsPool.java
@@ -160,7 +160,7 @@ public boolean offer(String uri, Channel channel) {
             IdleChannel idleChannel = new IdleChannel(uri, channel);
             added = idleConnectionForHost.add(idleChannel);
             if (channel2IdleChannel.put(channel, idleChannel) != null) {
-                log.error("Bas, this channel entry already exists in the connections pool!");
+                log.error("Channel {} already exists in the connections pool!", channel);
             }
         } else {
             log.debug("Maximum number of requests per host reached {} for {}", maxConnectionPerHost, uri);

Original file line number	Diff line number	Diff line change
`@@ -160,7 +160,7 @@ public boolean offer(String uri, Channel channel) {`
`160`	`160`	`IdleChannel idleChannel = new IdleChannel(uri, channel);`
`161`	`161`	`added = idleConnectionForHost.add(idleChannel);`
`162`	`162`	`if (channel2IdleChannel.put(channel, idleChannel) != null) {`
`163`		`- log.error("Bas, this channel entry already exists in the connections pool!");`
	`163`	`+ log.error("Channel {} already exists in the connections pool!", channel);`
`164`	`164`	`}`
`165`	`165`	`} else {`
`166`	`166`	`log.debug("Maximum number of requests per host reached {} for {}", maxConnectionPerHost, uri);`