Skip to content

Commit 75a65f6

Browse files
rokupsocornut
authored andcommitted
CI: Test build with large indices, obsolete functions disabled and demo/metrics windows disabled.
+ amend notes
1 parent 339ffd2 commit 75a65f6

File tree

3 files changed

+30
-2
lines changed

3 files changed

+30
-2
lines changed

.github/workflows/build.yml

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -203,6 +203,31 @@ jobs:
203203
echo '#include "examples/example_null/main.cpp"' >> example_single_file.cpp
204204
g++ -I. -Wall -Wformat -o example_single_file example_single_file.cpp
205205
206+
- name: Build example_null (with large ImDrawIdx)
207+
run: |
208+
echo '#define ImDrawIdx unsigned int' > example_single_file.cpp
209+
echo '#define IMGUI_IMPLEMENTATION' >> example_single_file.cpp
210+
echo '#include "misc/single_file/imgui_single_file.h"' >> example_single_file.cpp
211+
echo '#include "examples/example_null/main.cpp"' >> example_single_file.cpp
212+
g++ -I. -Wall -Wformat -o example_single_file example_single_file.cpp
213+
214+
- name: Build example_null (with IMGUI_DISABLE_OBSOLETE_FUNCTIONS)
215+
run: |
216+
echo '#define IMGUI_DISABLE_OBSOLETE_FUNCTIONS' > example_single_file.cpp
217+
echo '#define IMGUI_IMPLEMENTATION' >> example_single_file.cpp
218+
echo '#include "misc/single_file/imgui_single_file.h"' >> example_single_file.cpp
219+
echo '#include "examples/example_null/main.cpp"' >> example_single_file.cpp
220+
g++ -I. -Wall -Wformat -o example_single_file example_single_file.cpp
221+
222+
- name: Build example_null (with IMGUI_DISABLE_DEMO_WINDOWS and IMGUI_DISABLE_METRICS_WINDOW)
223+
run: |
224+
echo '#define IMGUI_DISABLE_DEMO_WINDOWS' > example_single_file.cpp
225+
echo '#define IMGUI_DISABLE_METRICS_WINDOW' >> example_single_file.cpp
226+
echo '#define IMGUI_IMPLEMENTATION' >> example_single_file.cpp
227+
echo '#include "misc/single_file/imgui_single_file.h"' >> example_single_file.cpp
228+
echo '#include "examples/example_null/main.cpp"' >> example_single_file.cpp
229+
g++ -I. -Wall -Wformat -o example_single_file example_single_file.cpp
230+
206231
- name: Build example_glfw_opengl2
207232
run: make -C examples/example_glfw_opengl2
208233

docs/CHANGELOG.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,9 @@ Other Changes:
5858
window also manipulate the ItemFlags stack. (#3024) [@Stanbroek]
5959
- Font: Fixed non-ASCII space occasionally creating unnecessary empty polygons.
6060
- Demo: Added black and white and color gradients to Demo>Examples>Custom Rendering.
61+
- CI: Added more tests on the continuous-integration server: extra warnings for Clang/GCC, building
62+
SDL+Metal example, and more compile-time imconfig.h settings: disabling obsolete functions,
63+
enabling 32-bit draw indices, enabling 32-bit ImWchar, disabling demo/metrics, etc. [@rokups]
6164
- Backends: Win32: Added ImGui_ImplWin32_EnableDpiAwareness(), ImGui_ImplWin32_GetDpiScaleForHwnd(),
6265
ImGui_ImplWin32_GetDpiScaleForMonitor() helpers functions (backported from the docking branch).
6366
Those functions makes it easier for example apps to support hi-dpi features without setting up

docs/TODO.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@ It's mostly a bunch of personal notes, probably incomplete. Feel free to query i
1414
- window: calling SetNextWindowSize() every frame with <= 0 doesn't do anything, may be useful to allow (particularly when used for a single axis). (#690)
1515
- window: add a way for very transient windows (non-saved, temporary overlay over hundreds of objects) to "clean" up from the global window list. perhaps a lightweight explicit cleanup pass.
1616
- window: auto-fit feedback loop when user relies on any dynamic layout (window width multiplier, column) appears weird to end-user. clarify.
17-
- window: allow resizing of child windows (possibly given min/max for each axis?.)
18-
- window: background options for child windows, border option (disable rounding).
1917
- window: begin with *p_open == false could return false.
2018
- window: get size/pos helpers given names (see discussion in #249)
2119
- window: a collapsed window can be stuck behind the main menu bar?
@@ -31,6 +29,8 @@ It's mostly a bunch of personal notes, probably incomplete. Feel free to query i
3129
- window: the size_on_first_use path of Begin() can probably be removed
3230
- window/size: manually triggered auto-fit (double-click on grip) shouldn't resize window down to viewport size?
3331
- window/opt: freeze window flag: if not focused/hovered, return false, render with previous ImDrawList. and/or reduce refresh rate. -> this may require enforcing that it is illegal to submit contents if Begin returns false.
32+
- window/child: background options for child windows, border option (disable rounding).
33+
- window/child: allow resizing of child windows (possibly given min/max for each axis?.)
3434
- window/child: the first draw command of a child window could be moved into the current draw command of the parent window (unless child+tooltip?).
3535
- window/child: border could be emitted in parent as well.
3636
- window/child: allow SetNextWindowContentSize() to work on child windows.

0 commit comments

Comments
 (0)