[NtUser] Unnecessary check is removed and correct value of an error code is returned

Dmitry Chapyshev · Dmitry Chapyshev · commit 50ce1f169459 · 2016-09-10T22:30:53.000Z
* Fixes 2 tests for win32knt_apitest:NtUserEnumDisplaySettings

svn path=/trunk/; revision=72649
diff --git a/reactos/win32ss/user/ntuser/display.c b/reactos/win32ss/user/ntuser/display.c
@@ -477,9 +477,6 @@ UserEnumDisplaySettings(
         return STATUS_UNSUCCESSFUL;
     }
 
-    if (iModeNum >= pGraphicsDevice->cDevModes)
-        return STATUS_NO_MORE_ENTRIES;
-
     iFoundMode = 0;
     for (i = 0; i < pGraphicsDevice->cDevModes; i++)
     {
@@ -504,7 +501,7 @@ UserEnumDisplaySettings(
     }
 
     /* Nothing was found */
-    return STATUS_INVALID_PARAMETER;
+    return STATUS_INVALID_PARAMETER_2;
 }
 
 NTSTATUS

Original file line number	Diff line number	Diff line change
`@@ -477,9 +477,6 @@ UserEnumDisplaySettings(`
`477`	`477`	`return STATUS_UNSUCCESSFUL;`
`478`	`478`	`}`
`479`	`479`
`480`		`- if (iModeNum >= pGraphicsDevice->cDevModes)`
`481`		`- return STATUS_NO_MORE_ENTRIES;`
`482`		`-`
`483`	`480`	`iFoundMode = 0;`
`484`	`481`	`for (i = 0; i < pGraphicsDevice->cDevModes; i++)`
`485`	`482`	`{`
`@@ -504,7 +501,7 @@ UserEnumDisplaySettings(`
`504`	`501`	`}`
`505`	`502`
`506`	`503`	`/* Nothing was found */`
`507`		`- return STATUS_INVALID_PARAMETER;`
	`504`	`+ return STATUS_INVALID_PARAMETER_2;`
`508`	`505`	`}`
`509`	`506`
`510`	`507`	`NTSTATUS`