Skip to content

Commit a9ee632

Browse files
committed
[0.4.8] revert "[RTL] find_string_index: name parameter may not be null terminated"
This reverts commit 0.4.8-dev-501-g 51c6942 An addendum to my last 0.4.8-commit reverting most sxs-works. It aims to prevent CORE-14475 which probably has been introduced by reverting only partially before. I tested resulting state for more than a week and could not trigger CORE-14475 any longer.
1 parent 11bf8fa commit a9ee632

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

sdk/lib/rtl/actctx.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3227,8 +3227,7 @@ static struct string_index *find_string_index(const struct strsection_header *se
32273227
{
32283228
const WCHAR *nameW = (WCHAR*)((BYTE*)section + iter->name_offset);
32293229

3230-
if (!_wcsnicmp(nameW, name->Buffer, name->Length / sizeof(WCHAR)) &&
3231-
wcslen(nameW) == name->Length / sizeof(WCHAR))
3230+
if (!strcmpiW(nameW, name->Buffer))
32323231
{
32333232
index = iter;
32343233
break;

0 commit comments

Comments
 (0)