[NTOSKRNL/MM]

 - assert PDE ref count consistency everywhere
 - fix the fix(tm) : after reference decrement, the maximum must not be reached

svn path=/trunk/; revision=55925

Author: zefklop

reactos/ntoskrnl/mm/ARM3/virtual.c

@@ -412,7 +412,7 @@ MiDeleteVirtualAddresses(IN ULONG_PTR Va,
             {
                 DPRINT("Decrement used PTEs by address: %lx\n", Va);
                 (*UsedPageTableEntries)--;
-                ASSERT((*UsedPageTableEntries) <= PTE_COUNT);
+                ASSERT((*UsedPageTableEntries) < PTE_COUNT);
                 DPRINT("Refs: %lx\n", (*UsedPageTableEntries));
 
                 /* Check if the PTE is actually mapped in */

reactos/ntoskrnl/mm/anonmem.c

@@ -117,6 +117,7 @@ MmPageOutVirtualMemory(PMMSUPPORT AddressSpace,
         else if(Address < MmSystemRangeStart)
         {
             AddressSpace->VmWorkingSetList->UsedPageTableEntries[MiGetPdeOffset(Address)]--;
+            ASSERT(AddressSpace->VmWorkingSetList->UsedPageTableEntries[MiGetPdeOffset(Address)] < PTE_COUNT);
         }
 #endif
         MmUnlockAddressSpace(AddressSpace);
@@ -416,6 +417,7 @@ MmModifyAttributes(PMMSUPPORT AddressSpace,
                 if(Address < MmSystemRangeStart)
                 {
                     AddressSpace->VmWorkingSetList->UsedPageTableEntries[MiGetPdeOffset(Address)]--;
+                    ASSERT(AddressSpace->VmWorkingSetList->UsedPageTableEntries[MiGetPdeOffset(Address)] < PTE_COUNT);
                 }
 #endif
             }
@@ -440,6 +442,7 @@ MmModifyAttributes(PMMSUPPORT AddressSpace,
                     if(Address < MmSystemRangeStart)
                     {
                         AddressSpace->VmWorkingSetList->UsedPageTableEntries[MiGetPdeOffset(Address)]--;
+                        ASSERT(AddressSpace->VmWorkingSetList->UsedPageTableEntries[MiGetPdeOffset(Address)] < PTE_COUNT);
                     }
 #endif
                 }

reactos/ntoskrnl/mm/marea.c

@@ -758,7 +758,7 @@ MmFreeMemoryArea(
             {
                 ASSERT(AddressSpace != MmGetKernelAddressSpace());
                 MmWorkingSetList->UsedPageTableEntries[MiGetPdeOffset(Address)]--;
-                ASSERT(MmWorkingSetList->UsedPageTableEntries[MiGetPdeOffset(Address)] <= PTE_COUNT);
+                ASSERT(MmWorkingSetList->UsedPageTableEntries[MiGetPdeOffset(Address)] < PTE_COUNT);
                 if(MmWorkingSetList->UsedPageTableEntries[MiGetPdeOffset(Address)] == 0)
                 {
                     /* No PTE relies on this PDE. Release it */

reactos/ntoskrnl/mm/section.c

@@ -1602,6 +1602,7 @@ MmNotPresentFaultSectionView(PMMSUPPORT AddressSpace,
         if(Address < MmSystemRangeStart)
         {
             MmWorkingSetList->UsedPageTableEntries[MiGetPdeOffset(Address)]--;
+            ASSERT(MmWorkingSetList->UsedPageTableEntries[MiGetPdeOffset(Address)] < PTE_COUNT);
         }
 #endif
          MmLockAddressSpace(AddressSpace);
@@ -1978,7 +1979,7 @@ MmPageOutDeleteMapping(PVOID Context, PEPROCESS Process, PVOID Address)
     if((Address < MmSystemRangeStart) && (Process != PageOutContext->CallingProcess))
     {
         Process->Vm.VmWorkingSetList->UsedPageTableEntries[MiGetPdeOffset(Address)]--;
-        ASSERT(Process->Vm.VmWorkingSetList->UsedPageTableEntries[MiGetPdeOffset(Address)] <= PTE_COUNT);
+        ASSERT(Process->Vm.VmWorkingSetList->UsedPageTableEntries[MiGetPdeOffset(Address)] < PTE_COUNT);
     }
 #endif
 
@@ -2158,7 +2159,7 @@ MmPageOutSectionView(PMMSUPPORT AddressSpace,
         if(Address < MmSystemRangeStart)
         {
             Process->Vm.VmWorkingSetList->UsedPageTableEntries[MiGetPdeOffset(Address)]--;
-            ASSERT(Process->Vm.VmWorkingSetList->UsedPageTableEntries[MiGetPdeOffset(Address)] <= PTE_COUNT);
+            ASSERT(Process->Vm.VmWorkingSetList->UsedPageTableEntries[MiGetPdeOffset(Address)] < PTE_COUNT);
         }
 #endif
          MmSetSavedSwapEntryPage(Page, 0);
@@ -2186,7 +2187,7 @@ MmPageOutSectionView(PMMSUPPORT AddressSpace,
          if(Address < MmSystemRangeStart)
          {
             Process->Vm.VmWorkingSetList->UsedPageTableEntries[MiGetPdeOffset(Address)]--;
-            ASSERT(Process->Vm.VmWorkingSetList->UsedPageTableEntries[MiGetPdeOffset(Address)] <= PTE_COUNT);
+            ASSERT(Process->Vm.VmWorkingSetList->UsedPageTableEntries[MiGetPdeOffset(Address)] < PTE_COUNT);
          }
 #endif
          MmSetSavedSwapEntryPage(Page, 0);
@@ -2247,7 +2248,7 @@ MmPageOutSectionView(PMMSUPPORT AddressSpace,
       if(Address < MmSystemRangeStart)
       {
          Process->Vm.VmWorkingSetList->UsedPageTableEntries[MiGetPdeOffset(Address)]--;
-         ASSERT(Process->Vm.VmWorkingSetList->UsedPageTableEntries[MiGetPdeOffset(Address)] <= PTE_COUNT);
+         ASSERT(Process->Vm.VmWorkingSetList->UsedPageTableEntries[MiGetPdeOffset(Address)] < PTE_COUNT);
       }
 #endif
       MmReleasePageMemoryConsumer(MC_USER, Page);
@@ -2413,7 +2414,7 @@ MmPageOutSectionView(PMMSUPPORT AddressSpace,
       if(Address < MmSystemRangeStart)
       {
          Process->Vm.VmWorkingSetList->UsedPageTableEntries[MiGetPdeOffset(Address)]--;
-         ASSERT(Process->Vm.VmWorkingSetList->UsedPageTableEntries[MiGetPdeOffset(Address)] <= PTE_COUNT);
+         ASSERT(Process->Vm.VmWorkingSetList->UsedPageTableEntries[MiGetPdeOffset(Address)] < PTE_COUNT);
       }
 #endif
       Entry = MAKE_SWAP_SSE(SwapEntry);