Skip to content

Commit e8d8b65

Browse files
committed
[FTFD]
Fix a typo, add a trace, add a comment svn path=/branches/GSoC_2011/GdiFontDriver/; revision=56203
1 parent 42b33d8 commit e8d8b65

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

drivers/video/font/ftfd/glyph.c

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -188,6 +188,7 @@ FtfdCreateFontInstance(
188188
/* Check if there is rotation / skewing (cannot use iComplexity!?) */
189189
if (!FLOATOBJ_bIsNull(&fxform.eM12) || !FLOATOBJ_bIsNull(&fxform.eM21))
190190
{
191+
TRACE("Setting extended xform\n");
191192
//__debugbreak();
192193

193194
/* Create a transformation matrix that is applied after the character
@@ -386,15 +387,18 @@ FtfdQueryMaxExtents(
386387
}
387388

388389
/* Copy some values from the font structure */
389-
pfddm->fxMaxAscender = (pfont->metrics.fxMaxAscender + 15) & ~0x0f;
390-
pfddm->fxMaxDescender = (pfont->metrics.fxMaxDescender + 15) & ~0x0f;
391390
pfddm->ptlUnderline1 = pfont->metrics.ptlUnderline1;
392391
pfddm->ptlStrikeout = pfont->metrics.ptlStrikeout;
393392
pfddm->ptlULThickness = pfont->metrics.ptlULThickness;
394393
pfddm->ptlSOThickness = pfont->metrics.ptlSOThickness;
395394
pfddm->cxMax = pfont->sizlMax.cx;
396395
pfddm->cyMax = pfont->sizlMax.cy;
397396

397+
/* These values are rounded to pixels to fix inconsistent height
398+
of marked text and the rest of the marked row in XP list boxes */
399+
pfddm->fxMaxAscender = (pfont->metrics.fxMaxAscender + 15) & ~0x0f;
400+
pfddm->fxMaxDescender = (pfont->metrics.fxMaxDescender + 15) & ~0x0f;
401+
398402
/* Convert the base vectors from FLOATOBJ to FLOATL */
399403
pfddm->pteBase.x = FLOATOBJ_GetFloat(&pfont->ptefBase.x);
400404
pfddm->pteBase.y = FLOATOBJ_GetFloat(&pfont->ptefBase.y);
@@ -460,7 +464,7 @@ FtfdQueryGlyphData(
460464
/* D is the glyph advance width. Convert it from 26.6 to 28.4 fixpoint format */
461465
pgd->fxD = ftglyph->advance.x >> 2; // FIXME: should be projected on the x-axis
462466

463-
/* Get the bitnmap size */
467+
/* Get the bitmap size */
464468
sizlBitmap.cx = ftglyph->bitmap.width;
465469
sizlBitmap.cy = ftglyph->bitmap.rows;
466470

drivers/video/font/ftfd/tttables.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ CalcTableChecksum(PVOID pvTable, ULONG cjTable)
2929
* \brief Searches for a specific table in TrueType and OpenType font files
3030
* \param pvView - The address where the font file is mapped
3131
* \param cjView - Size of the mapped font file
32-
* \param iFace - 1-based index of the font in the font file.
32+
* \param ulFont - 1-based index of the font in the font file.
3333
* \param ulTag - Identifier tag of the table to search
3434
* \param pulLength - Pointer to an ULONG that recieves the table length,
3535
* Can be NULL.

0 commit comments

Comments
 (0)