stricter checking of params in curl

Justin Bishop · Justin Bishop · commit ca392cca564c · 2011-09-01T14:20:10.000-07:00
Summary:

Reviewers:

Test Plan:

Task ID:
diff --git a/WebDriverBase.php b/WebDriverBase.php
@@ -32,7 +32,7 @@ protected function curl(http://github.com/$http_method,%22,%22html%22:%22@@%20-32,7%20+32,7%20@@%20protected%20function%20curl($http_method,%22,%22displayNoNewLineWarning%22:false,%22position%22:0,%22left%22:31,%22right%22:31%7D,%7B%22type%22:%22CONTEXT%22,%22blobLineNumber%22:32,%22text%22:%22%20%20%20%20%20%7D%22,%22html%22:%22%20%20%20%20%20%7D%22,%22displayNoNewLineWarning%22:false,%22position%22:1,%22left%22:32,%22right%22:32%7D,%7B%22type%22:%22CONTEXT%22,%22blobLineNumber%22:33,%22text%22:%22%20%22,%22html%22:%22/u003cbr/u003e%22,%22displayNoNewLineWarning%22:false,%22position%22:2,%22left%22:33,%22right%22:33%7D,%7B%22type%22:%22CONTEXT%22,%22blobLineNumber%22:34,%22text%22:%22%20%20%20%20%20$url%20=%20sprintf('%s%s',%20$this-/u003eurl,%20$command);
-    if ($params && !is_array($params)) {
+    if ($params && (is_int($params) || is_string($params))) {
       $url .= '/' . $params;
     }
 

Original file line number	Diff line number	Diff line change
@@ -32,7 +32,7 @@ protected function curl(http://github.com/$http_method,%3C/div%3E%3C/code%3E%3C/div%3E%3C/td%3E%3C/tr%3E%3Ctr%20class=%22diff-line-row%22%3E%3Ctd%20data-grid-cell-id=%22diff-c67b530e1cad5dad010923b03baf2dfde7fca2a61353687ea2601a810879dde0-32-32-0%22%20data-selected=%22false%22%20role=%22gridcell%22%20style=%22background-color:var(--bgColor-default);text-align:center" tabindex="-1" valign="top" class="focusable-grid-cell diff-line-number position-relative diff-line-number-neutral left-side">32			`32`	`}`
`33`	`33`
`34`	`34`	`$url = sprintf('%s%s', $this->url, $command);`
`35`		`- if ($params && !is_array($params)) {`
	`35`	`+ if ($params && (is_int($params) \|\| is_string($params))) {`
`36`	`36`	`$url .= '/' . $params;`
`37`	`37`	`}`
`38`	`38`