Make timer tests run for all loops, contains failing libevent case

Author: igorw

tests/React/Tests/EventLoop/LibEvLoopTest.php

@@ -2,7 +2,6 @@
 
 namespace React\Tests\EventLoop;
 
-use React\EventLoop\LoopInterface;
 use React\EventLoop\LibEvLoop;
 
 class LibEvLoopTest extends AbstractLoopTest

tests/React/Tests/EventLoop/LibEventLoopTest.php

@@ -2,7 +2,6 @@
 
 namespace React\Tests\EventLoop;
 
-use React\EventLoop\LoopInterface;
 use React\EventLoop\LibEventLoop;
 
 class LibEventLoopTest extends AbstractLoopTest

tests/React/Tests/EventLoop/StreamSelectLoopTest.php

@@ -2,7 +2,6 @@
 
 namespace React\Tests\EventLoop;
 
-use React\EventLoop\LoopInterface;
 use React\EventLoop\StreamSelectLoop;
 
 class StreamSelectLoopTest extends AbstractLoopTest

tests/React/Tests/EventLoop/TimerTest.php …ts/EventLoop/Timer/AbstractTimerTest.phptests/React/Tests/EventLoop/TimerTest.php renamed to tests/React/Tests/EventLoop/Timer/AbstractTimerTest.php tests/React/Tests/EventLoop/TimerTest.php renamed to tests/React/Tests/EventLoop/Timer/AbstractTimerTest.php

@@ -1,17 +1,13 @@
 <?php
 
-namespace React\Tests\EventLoop;
+namespace React\Tests\EventLoop\Timer;
 
 use React\Tests\Socket\TestCase;
-use React\EventLoop\StreamSelectLoop;
 use React\EventLoop\Timer\Timers;
 
-class TimerTest extends TestCase
+abstract class AbstractTimerTest extends TestCase
 {
-    private function createLoop()
-    {
-        return new StreamSelectLoop();
-    }
+    abstract public function createLoop();
 
     /**
      * @covers React\EventLoop\StreamSelectLoop::tick

tests/React/Tests/EventLoop/Timer/LibEvTimerTest.php

@@ -0,0 +1,17 @@
+<?php
+
+namespace React\Tests\EventLoop\Timer;
+
+use React\EventLoop\LibEvLoop;
+
+class LibEvTimerTest extends AbstractTimerTest
+{
+    public function createLoop()
+    {
+        if (!class_exists('libev\EventLoop')) {
+            $this->markTestSkipped('libev tests skipped because ext-libev is not installed.');
+        }
+
+        return new LibEvLoop();
+    }
+}

tests/React/Tests/EventLoop/Timer/LibEventTimerTest.php

@@ -0,0 +1,19 @@
+<?php
+
+namespace React\Tests\EventLoop\Timer;
+
+use React\EventLoop\LibEventLoop;
+
+class LibEventTimerTest extends AbstractTimerTest
+{
+    public function createLoop()
+    {
+        $this->markTestSkipped('libevent timers are currently broken.');
+
+        if (!function_exists('event_base_new')) {
+            $this->markTestSkipped('libevent tests skipped because ext-libevent is not installed.');
+        }
+
+        return new LibEventLoop();
+    }
+}

tests/React/Tests/EventLoop/Timer/StreamSelectTimerTest.php

@@ -0,0 +1,13 @@
+<?php
+
+namespace React\Tests\EventLoop\Timer;
+
+use React\EventLoop\StreamSelectLoop;
+
+class StreamSelectTimerTest extends AbstractTimerTest
+{
+    public function createLoop()
+    {
+        return new StreamSelectLoop();
+    }
+}