Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: coreos/coreos-assembler
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: coreos/coreos-assembler
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: rhcos-4.15
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 13 commits
  • 12 files changed
  • 6 contributors

Commits on Feb 8, 2024

  1. Add platforms JSON as part of the container

     Incorporate the platforms JSON file into the container,
     as it is essential for our OSBuild requirements.
    
    Signed-off-by: Renata Ravanelli <[email protected]>
    (cherry picked from commit 410cf90)
    ravanelli authored and dustymabe committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    5048f53 View commit details
    Browse the repository at this point in the history
  2. cmdlib: rework platforms.json handling

    Addition of platforms.json was originally added in 410cf90. Here
    we make a few improvements:
    
    - We don't need to export platforms_json has that wasn't being done
      before 410cf90.
    - We need to only create a file that gets included in the OSTree
      or Container if there are platforms.yaml entries for that arch.
      So we modify it here to create "${platforms_json}.all" first and
      only write to "${platforms_json}" inside the if condition. This
      makes it so s390x won't get a platforms.json file, which is what
      we want.
    - We need to create these files in directories scoped to individual
      processes. i.e. if `cosa buildextend-metal` and `cosa buildextend-metal4k`
      run at the same time creating these files shouldn't race.
    
    (cherry picked from commit 509f470)
    dustymabe committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    06c21d0 View commit details
    Browse the repository at this point in the history
  3. .cci.Jenkinsfile: drop Fedora CoreOS testing

    It doesn't work properly against these rhcos- branches anyway. Let's
    just limit the testing to building the container and running check
    and unittest tests.
    
    (cherry picked from commit 511a61d)
    jlebon authored and dustymabe committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    570ef0b View commit details
    Browse the repository at this point in the history
  4. Dockerfile: drop patching of OSBuild

    The version of OSBuild in the F39 repos is newer now and the patches
    don't apply any more. In the main branch we've solved this by pinning
    OSBuild on specific versions. For 4.15 we don't even need to do
    the patching because we aren't building using OSBuild in the pipeline
    for 4.15.
    dustymabe committed Feb 8, 2024
    Configuration menu
    Copy the full SHA
    743c05b View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2024

  1. mantle/platform/aliyun: modify the API to use HTTPS by default

    Attempting to override the http scheme for each request is not working
    for every request type. Let's set the client config scheme to HTTPS by default.
    Move away from `NewClientWithAccessKey` and instead create an access key
    separately and then use `NewClientWithOptions` to create the client with a
    custom config using "HTTPS" for the scheme.
    Also remove the scheme override for each request.
    marmijo committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    759467d View commit details
    Browse the repository at this point in the history
  2. Revert "ci: Use scos (at least for now)"

    This reverts commit 0b659af.
    
    That was meant to be a temporary measure but lingered for a while. As
    mentioned there, ideally, we'd build both, but if we only build one, let
    it be RHCOS.
    jlebon authored and marmijo committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    b0e87e4 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. aliyun: make image replication idempotent

    There is a history of failure copying images to other regions on
    aliyun. Upstream code that calls the CopyImage code more than once
    will get a DuplicateImage error when an image with the same name
    already exists. Let's check to see if the image name exists in the
    region before attempting to copy the image to the region and return
    early if it already exists.
    mike-nguyen authored and dustymabe committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    16f2fb6 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Add cosa supermin-run

    This is very close to `cosa supermin-shell` but instead expects a
    command to run inside the supermin VM. Essentially, it's a very thin
    wrapper around the `runvm` family of functions in `cmdlib.sh`.
    
    By having it be a dedicated function, it becomes like a utility command
    to have easy access to a privileged environment, with the working dir
    automatically mounted in, podman remote proxying, etc... Note also this
    *does not* require a cosa workdir.
    
    The podman machine OS pipeline will be using this temporarily.
    jlebon authored and dustymabe committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    5999f6f View commit details
    Browse the repository at this point in the history
  2. supermin-init-prelude: skip creating cache dir

    In a cosa workdir, that dir always exists in both privileged and
    unprivileged paths.
    
    Prep for a new command that'll use this code outside a cosa workdir
    where to be nice we don't want to just randomly create a cache dir even
    when no caching is required.
    jlebon authored and dustymabe committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    a65147c View commit details
    Browse the repository at this point in the history
  3. cmdlib.sh: feed /dev/zero as qemu stdin

    This is a follow-up to 79b15c8 ("cmdlib.sh: go back to using `tail -F`
    for command output") which was subsequently reverted.
    
    To summarize, it seems like in QEMU v8.2 (in f40), the guest sometimes
    would hang when writing over virtio-serial if the device is hooked up to
    the QEMU's stdio.
    
    In testing, removing the `<&-` hack to close QEMU's stdin fixed it for
    CoreOS CI but not Prow:
    
    #3785 (comment)
    
    I think I've narrowed it down to CoreOS CI (i.e. Jenkins) allocating a
    tty and Prow not. When stdin is not a tty, QEMU would immediately gets
    EOF if it tries to read anything. I'm not sure exactly what happens, but
    I think the virtio-serial hang is linked to this (even though there's no
    userspace code in the guest trying to read from the virtio-serial port).
    
    Work around this by explicitly feeding `/dev/zero` to QEMU's stdin.
    
    (cherry picked from commit bb60451)
    jlebon authored and dustymabe committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    eb0403a View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. support cosa buildextend-qemu-secex

    `qemu-secex` is the artifact name used in meta.json and elsewhere
    so let's support calling it that way like we do for other artifacts.
    
    The `cmd-buildextend-secex` symlink is left in place for backwards
    compatibilty.
    
    (cherry picked from commit 85931e4)
    dustymabe committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    43069be View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. mantle/platform/aws: handle missing details fields

    Possibly something changed on the AWS side, but we're seeing what looks
    like `SnapshotTaskDetail` structs coming back with some of the fields
    empty. Gracefully handle this case.
    jlebon authored and marmijo committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    7703657 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2025

  1. kola/tests: Add failing test for FIPS & LUKS

    Ensure that setting up a LUKS device with FIPS incompatible algorithms
    will fail when FIPS mode is enabled.
    
    Only run this on QEMU as it should behave the same way on all platforms.
    travier authored and mike-nguyen committed Oct 13, 2025
    Configuration menu
    Copy the full SHA
    60a396f View commit details
    Browse the repository at this point in the history
Loading