- 
                Notifications
    
You must be signed in to change notification settings  - Fork 184
 
Comparing changes
Open a pull request
base repository: coreos/coreos-assembler
base: main
head repository: coreos/coreos-assembler
compare: rhcos-4.15
- 13 commits
 - 12 files changed
 - 6 contributors
 
Commits on Feb 8, 2024
- 
  
Add platforms JSON as part of the container
Incorporate the platforms JSON file into the container, as it is essential for our OSBuild requirements. Signed-off-by: Renata Ravanelli <[email protected]> (cherry picked from commit 410cf90)
Configuration menu - View commit details
 - 
    
    
    
Copy full SHA for 5048f53  - Browse repository at this point
 
Copy the full SHA 5048f53View commit details  - 
  
cmdlib: rework platforms.json handling
Addition of platforms.json was originally added in 410cf90. Here we make a few improvements: - We don't need to export platforms_json has that wasn't being done before 410cf90. - We need to only create a file that gets included in the OSTree or Container if there are platforms.yaml entries for that arch. So we modify it here to create "${platforms_json}.all" first and only write to "${platforms_json}" inside the if condition. This makes it so s390x won't get a platforms.json file, which is what we want. - We need to create these files in directories scoped to individual processes. i.e. if `cosa buildextend-metal` and `cosa buildextend-metal4k` run at the same time creating these files shouldn't race. (cherry picked from commit 509f470)
Configuration menu - View commit details
 - 
    
    
    
Copy full SHA for 06c21d0  - Browse repository at this point
 
Copy the full SHA 06c21d0View commit details  - 
  
.cci.Jenkinsfile: drop Fedora CoreOS testing
It doesn't work properly against these rhcos- branches anyway. Let's just limit the testing to building the container and running check and unittest tests. (cherry picked from commit 511a61d)
Configuration menu - View commit details
 - 
    
    
    
Copy full SHA for 570ef0b  - Browse repository at this point
 
Copy the full SHA 570ef0bView commit details  - 
  
Dockerfile: drop patching of OSBuild
The version of OSBuild in the F39 repos is newer now and the patches don't apply any more. In the main branch we've solved this by pinning OSBuild on specific versions. For 4.15 we don't even need to do the patching because we aren't building using OSBuild in the pipeline for 4.15.
Configuration menu - View commit details
 - 
    
    
    
Copy full SHA for 743c05b  - Browse repository at this point
 
Copy the full SHA 743c05bView commit details  
Commits on Aug 21, 2024
- 
  
mantle/platform/aliyun: modify the API to use HTTPS by default
Attempting to override the http scheme for each request is not working for every request type. Let's set the client config scheme to HTTPS by default. Move away from `NewClientWithAccessKey` and instead create an access key separately and then use `NewClientWithOptions` to create the client with a custom config using "HTTPS" for the scheme. Also remove the scheme override for each request.
Configuration menu - View commit details
 - 
    
    
    
Copy full SHA for 759467d  - Browse repository at this point
 
Copy the full SHA 759467dView commit details  - 
  
Revert "ci: Use scos (at least for now)"
This reverts commit 0b659af. That was meant to be a temporary measure but lingered for a while. As mentioned there, ideally, we'd build both, but if we only build one, let it be RHCOS.
Configuration menu - View commit details
 - 
    
    
    
Copy full SHA for b0e87e4  - Browse repository at this point
 
Copy the full SHA b0e87e4View commit details  
Commits on Sep 13, 2024
- 
  
aliyun: make image replication idempotent
There is a history of failure copying images to other regions on aliyun. Upstream code that calls the CopyImage code more than once will get a DuplicateImage error when an image with the same name already exists. Let's check to see if the image name exists in the region before attempting to copy the image to the region and return early if it already exists.
Configuration menu - View commit details
 - 
    
    
    
Copy full SHA for 16f2fb6  - Browse repository at this point
 
Copy the full SHA 16f2fb6View commit details  
Commits on Oct 17, 2024
- 
  
This is very close to `cosa supermin-shell` but instead expects a command to run inside the supermin VM. Essentially, it's a very thin wrapper around the `runvm` family of functions in `cmdlib.sh`. By having it be a dedicated function, it becomes like a utility command to have easy access to a privileged environment, with the working dir automatically mounted in, podman remote proxying, etc... Note also this *does not* require a cosa workdir. The podman machine OS pipeline will be using this temporarily.
Configuration menu - View commit details
 - 
    
    
    
Copy full SHA for 5999f6f  - Browse repository at this point
 
Copy the full SHA 5999f6fView commit details  - 
  
supermin-init-prelude: skip creating cache dir
In a cosa workdir, that dir always exists in both privileged and unprivileged paths. Prep for a new command that'll use this code outside a cosa workdir where to be nice we don't want to just randomly create a cache dir even when no caching is required.
Configuration menu - View commit details
 - 
    
    
    
Copy full SHA for a65147c  - Browse repository at this point
 
Copy the full SHA a65147cView commit details  - 
  
cmdlib.sh: feed
/dev/zeroas qemu stdinThis is a follow-up to 79b15c8 ("cmdlib.sh: go back to using `tail -F` for command output") which was subsequently reverted. To summarize, it seems like in QEMU v8.2 (in f40), the guest sometimes would hang when writing over virtio-serial if the device is hooked up to the QEMU's stdio. In testing, removing the `<&-` hack to close QEMU's stdin fixed it for CoreOS CI but not Prow: #3785 (comment) I think I've narrowed it down to CoreOS CI (i.e. Jenkins) allocating a tty and Prow not. When stdin is not a tty, QEMU would immediately gets EOF if it tries to read anything. I'm not sure exactly what happens, but I think the virtio-serial hang is linked to this (even though there's no userspace code in the guest trying to read from the virtio-serial port). Work around this by explicitly feeding `/dev/zero` to QEMU's stdin. (cherry picked from commit bb60451)
Configuration menu - View commit details
 - 
    
    
    
Copy full SHA for eb0403a  - Browse repository at this point
 
Copy the full SHA eb0403aView commit details  
Commits on Nov 11, 2024
- 
  
support
cosa buildextend-qemu-secex`qemu-secex` is the artifact name used in meta.json and elsewhere so let's support calling it that way like we do for other artifacts. The `cmd-buildextend-secex` symlink is left in place for backwards compatibilty. (cherry picked from commit 85931e4)
Configuration menu - View commit details
 - 
    
    
    
Copy full SHA for 43069be  - Browse repository at this point
 
Copy the full SHA 43069beView commit details  
Commits on Nov 21, 2024
- 
  
mantle/platform/aws: handle missing details fields
Possibly something changed on the AWS side, but we're seeing what looks like `SnapshotTaskDetail` structs coming back with some of the fields empty. Gracefully handle this case.
Configuration menu - View commit details
 - 
    
    
    
Copy full SHA for 7703657  - Browse repository at this point
 
Copy the full SHA 7703657View commit details  
Commits on Oct 13, 2025
- 
  
kola/tests: Add failing test for FIPS & LUKS
Ensure that setting up a LUKS device with FIPS incompatible algorithms will fail when FIPS mode is enabled. Only run this on QEMU as it should behave the same way on all platforms.
Configuration menu - View commit details
 - 
    
    
    
Copy full SHA for 60a396f  - Browse repository at this point
 
Copy the full SHA 60a396fView commit details  
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
            You can try running this command locally to see the comparison on your machine: 
            git diff main...rhcos-4.15