Skip to content

Commit aa6e69d

Browse files
author
Tor Didriksen
committed
Backport patch for Bug#16877045 5.6-CLUSTER-7.3 WIN32 SQL_YACC.CC BUILD PROBLEM
Building with ninja shows the problem: cmake .. -G Ninja ninja ninja: error: dependency cycle: sql/GenServerSource -> sql/CMakeFiles/GenServerSource -> sql/sql_builtin.cc -> cmake_order_depends_target_sq sql/GenServerSource Bug#16877045 5.6-CLUSTER-7.3 WIN32 SQL_YACC.CC BUILD PROBLEM - Somewhat circular dependency caused by the configured files sql_builtin.cc being included as part of the files to generate in sql/ - Move sql_builtin.cc out of GEN_SOURCES variable. - Create new variable CONF_SOURCES to be used for configured files.
1 parent cf3fe5a commit aa6e69d

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

mysql-test/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Copyright (c) 2009, 2013, Oracle and/or its affiliates. All rights reserved.
1+
# Copyright (c) 2009, 2017, Oracle and/or its affiliates. All rights reserved.
22
#
33
# This program is free software; you can redistribute it and/or modify
44
# it under the terms of the GNU General Public License as published by
@@ -92,7 +92,7 @@ ENDIF()
9292

9393
IF(WITH_EMBEDDED_SERVER)
9494
SET(TEST_EMBEDDED ${MTR_FORCE} --comment=embedded --timer --embedded-server
95-
--skip-rpl --skip-ndbcluster $(EXP))
95+
--skip-rpl --skip-ndbcluster ${EXP})
9696
ELSE()
9797
SET(TEST_EMBEDDED echo "Can not test embedded, not compiled in")
9898
ENDIF()

sql/CMakeLists.txt

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Copyright (c) 2006, 2014, Oracle and/or its affiliates. All rights reserved.
1+
# Copyright (c) 2006, 2017, Oracle and/or its affiliates. All rights reserved.
22
#
33
# This program is free software; you can redistribute it and/or modify
44
# it under the terms of the GNU General Public License as published by
@@ -22,14 +22,16 @@ ${SSL_INCLUDE_DIRS}
2222
${CMAKE_BINARY_DIR}/sql
2323
)
2424

25+
SET(CONF_SOURCES
26+
${CMAKE_CURRENT_BINARY_DIR}/sql_builtin.cc
27+
)
2528
SET(GEN_SOURCES
2629
${CMAKE_CURRENT_BINARY_DIR}/sql_yacc.h
2730
${CMAKE_CURRENT_BINARY_DIR}/sql_yacc.cc
28-
${CMAKE_CURRENT_BINARY_DIR}/sql_builtin.cc
2931
${CMAKE_CURRENT_BINARY_DIR}/lex_hash.h
3032
)
3133

32-
SET_SOURCE_FILES_PROPERTIES(${GEN_SOURCES} PROPERTIES GENERATED 1)
34+
SET_SOURCE_FILES_PROPERTIES(${GEN_SOURCES} ${CONF_SOURCES} PROPERTIES GENERATED 1)
3335

3436
ADD_DEFINITIONS(-DMYSQL_SERVER -DHAVE_EVENT_SCHEDULER)
3537
IF(SSL_DEFINES)
@@ -78,6 +80,7 @@ SET (SQL_SOURCE
7880
transaction.cc sys_vars.cc sql_truncate.cc datadict.cc
7981
sql_reload.cc
8082
${GEN_SOURCES}
83+
${CONF_SOURCES}
8184
${MYSYS_LIBWRAP_SOURCE})
8285

8386
# These files have unused result errors, so we skip Werror

0 commit comments

Comments
 (0)