Bug #27461752 NDB-API, INDEXSCANOPERATION, INCORRECT RESULT WHEN NULL-BOUND IS SPECIFIED

Code generated for NdbIndexScanOperation::setBoundHelperOldApi() failed to set
the 'nullBit' mask correctly if a NULL value was specified for the 'bound'.

Was caused by 'delete-null-pointer-checks' optimization in gcc compiler,
in combination with memcpy() having the 'nonnull' property set for its two
pointer arguments. Thus it assumed that 'aValue != NULL' and eliminated
later code checking for 'aValue == NULL'

(cherry picked from commit e0a930454239e447e44c0ed9b0294e6ac3e05f75)

Author: Ole John Aske

storage/ndb/src/ndbapi/NdbScanOperation.cpp

@@ -1,5 +1,5 @@
 /*
-   Copyright (c) 2003, 2015, Oracle and/or its affiliates. All rights reserved.
+   Copyright (c) 2003, 2018, Oracle and/or its affiliates. All rights reserved.
 
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
@@ -3135,18 +3135,23 @@ NdbIndexScanOperation::setBoundHelperOldApi(OldApiBoundInfo& boundInfo,
     }
   }
 
-  /* Copy data into correct part of RecAttr */
-  assert(byteOffset + valueLen <= maxKeyRecordBytes);
-
-  memcpy(boundInfo.key + byteOffset,
-         aValue, 
-         valueLen);
-
-  /* Set Null bit */
-  bool nullBit=(aValue == NULL);
+  if (aValue != NULL)
+  {
+    /* Copy data into correct part of RecAttr */
+    assert(valueLen > 0);
+    assert(byteOffset + valueLen <= maxKeyRecordBytes);
 
-  boundInfo.key[nullbit_byte_offset]|= 
-    (nullBit) << nullbit_bit_in_byte;
+    memcpy(boundInfo.key + byteOffset,
+           aValue, 
+           valueLen);
+  }
+  else
+  {
+    /* Set Null bit */
+    assert(valueLen == 0);
+    boundInfo.key[nullbit_byte_offset] |= 
+      (1 << nullbit_bit_in_byte);
+  }
 
   return 0;
 }