Replaced magic number in swap_endianness

glynos · glynos · commit d49ec1040774 · 2020-11-02T14:17:28.000+01:00
diff --git a/include/skyr/v2/platform/endianness.hpp b/include/skyr/v2/platform/endianness.hpp
@@ -15,9 +15,10 @@ namespace details {
 template <class intT>
 requires std::is_integral_v<intT> constexpr inline auto swap_endianness(intT v) noexcept -> intT {
   constexpr auto byte_count = sizeof(v);
-  std::array<unsigned char, byte_count> bytes{};
-  for (auto i = 0UL; i < byte_count; ++i) {
-    bytes[i] = static_cast<unsigned char>(v >> (i * 8));
+  constexpr auto bit_count = 8ul;
+  std::array<std::byte, byte_count> bytes{};
+  for (auto i = 0ul; i < byte_count; ++i) {
+    bytes[i] = static_cast<std::byte>(v >> (i * bit_count));
   }
   return *static_cast<const intT *>(static_cast<const void *>(bytes.data()));
 }

Original file line number	Diff line number	Diff line change
`@@ -15,9 +15,10 @@ namespace details {`
`15`	`15`	`template <class intT>`
`16`	`16`	`requires std::is_integral_v<intT> constexpr inline auto swap_endianness(intT v) noexcept -> intT {`
`17`	`17`	`constexpr auto byte_count = sizeof(v);`
`18`		`- std::array<unsigned char, byte_count> bytes{};`
`19`		`- for (auto i = 0UL; i < byte_count; ++i) {`
`20`		`- bytes[i] = static_cast<unsigned char>(v >> (i * 8));`
	`18`	`+ constexpr auto bit_count = 8ul;`
	`19`	`+ std::array<std::byte, byte_count> bytes{};`
	`20`	`+ for (auto i = 0ul; i < byte_count; ++i) {`
	`21`	`+ bytes[i] = static_cast<std::byte>(v >> (i * bit_count));`
`21`	`22`	`}`
`22`	`23`	`return static_cast<const intT >(static_cast<const void *>(bytes.data()));`
`23`	`24`	`}`