cdk: Disable false -Warray-bounds and -Wstringop-overflow warnings

Author: rsomla1

CMakeLists.txt

@@ -299,7 +299,10 @@ endif()
 if (CMAKE_COMPILER_IS_GNUCC AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 12.0)
   # Silence a warning produced by a regression in GCC 12.0 and newer
   # https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106199
+  # Note: The stringop-overflow warnings are shown also during linking phase
+  # (observed with GCC 14.2)
   add_compile_options(-Wno-stringop-overflow)
+  add_link_options(-Wno-stringop-overflow)
 endif()
 
 

cdk/include/mysql/cdk/foundation/codec.h

@@ -220,8 +220,14 @@ static size_t convert(bytes buf, T &val)
     /*
       If buf size is smaller than sizeof(T), convert 1,2,4 or 8 initial
       bytes from the buffer: as much as fits into T.
+
+      Note: We check here that buffer size is big enough to store given amount
+      of bytes but compilers still complain under -Warray-bounds (seen on
+      Solaris with gcc 11.4).
     */
 
+PUSH_ARRAY_BOUNDS_WARNING_CDK
+
     if (buf.size() >= sizeof(T))
     {
       val= *(T*)buf.begin();
@@ -252,6 +258,8 @@ static size_t convert(bytes buf, T &val)
       return 1;
     }
 
+POP_ARRAY_BOUNDS_WARNING_CDK
+
     // TODO: better error description
     throw_error(cdkerrc::conversion_error,
                 "Number_codec: no data for conversion");

cdk/include/mysql/cdk/foundation/common.h

@@ -42,7 +42,7 @@
 #define DIAGNOSTIC_PUSH_CDK  PRAGMA_CDK(warning (push))
 #define DIAGNOSTIC_POP_CDK   PRAGMA_CDK(warning (pop))
 
-#elif defined __GNUC__ || defined __clang__ 
+#elif defined __GNUC__ || defined __clang__
 
 #define PRAGMA_CDK(X) _Pragma(#X)
 #define DISABLE_WARNING_CDK(W) PRAGMA_CDK(GCC diagnostic ignored #W)
@@ -113,6 +113,25 @@
 #define POP_SYS_WARNINGS_CDK  DIAGNOSTIC_POP_CDK
 
 
+/*
+  Macros to disable false positives from -Warray-bounds checks for lines
+  of code that were manually verified to be correct.
+*/
+
+#ifdef _MSC_VER
+
+#define PUSH_ARRAY_BOUNDS_WARNING_CDK DIAGNOSTIC_PUSH_CDK
+#define POP_ARRAY_BOUNDS_WARNING_CDK DIAGNOSTIC_POP_CDK
+
+#else
+
+#define PUSH_ARRAY_BOUNDS_WARNING_CDK \
+  DIAGNOSTIC_PUSH_CDK DISABLE_WARNING_CDK(-Warray-bounds)
+#define POP_ARRAY_BOUNDS_WARNING_CDK DIAGNOSTIC_POP_CDK
+
+#endif
+
+
 // Avoid warnings from Protobuf includes
 
 #if defined _MSC_VER