http code 204 was causing an error 500

Caio Iglesias · Caio Iglesias · commit 29975a23b458 · 2013-02-01T16:45:42.000-02:00
When trying to send back $this-&gt;response(null, 204) the code would
crash when handling the empty data.
diff --git a/application/libraries/REST_Controller.php b/application/libraries/REST_Controller.php
@@ -368,6 +368,12 @@ public function response($data = array(), $http_code = null)
 			$output = NULL;
 		}
 
+		// If data is empty but http code provided, keep the output empty
+		else if (empty($data) && is_numeric($http_code))
+		{
+			$output = NULL;
+		}
+
 		// Otherwise (if no data but 200 provided) or some data, carry on camping!
 		else
 		{

Original file line number	Diff line number	Diff line change
`@@ -368,6 +368,12 @@ public function response($data = array(), $http_code = null)`
`368`	`368`	`$output = NULL;`
`369`	`369`	`}`
`370`	`370`
	`371`	`+ // If data is empty but http code provided, keep the output empty`
	`372`	`+ else if (empty($data) && is_numeric($http_code))`
	`373`	`+ {`
	`374`	`+ $output = NULL;`
	`375`	`+ }`
	`376`	`+`
`371`	`377`	`// Otherwise (if no data but 200 provided) or some data, carry on camping!`
`372`	`378`	`else`
`373`	`379`	`{`