Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: cscott/node-php-embed
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: cscott/node-php-embed
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: node-1.8.4
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 10 commits
  • 18 files changed
  • 1 contributor

Commits on Oct 20, 2015

  1. Redo streaming from PHP as message-passing.

    @cscott
    cscott committed Oct 20, 2015
    Configuration menu
    Copy the full SHA
    3170fd2 View commit details
    Browse the repository at this point in the history

  2. Add context object to pass data from JavaScript to PHP.

    @cscott
    cscott committed Oct 20, 2015
    Configuration menu
    Copy the full SHA
    bda9516 View commit details
    Browse the repository at this point in the history

  3. Add "Buffer" type to allow passing PHP output as buffers to Node.

    @cscott
    cscott committed Oct 20, 2015
    Configuration menu
    Copy the full SHA
    8fabf27 View commit details
    Browse the repository at this point in the history

  4. Fix memory errors in read_property. 

    Use the __get magic method, instead of attempting to implement the
read_property handler, since the expected refcount properties of
the value returned from the read_property handler seem to be exceedingly
baroque.
    @cscott
    cscott committed Oct 20, 2015
    Configuration menu
    Copy the full SHA
    304000e View commit details
    Browse the repository at this point in the history

  5. Add segfault handler for debugging crashes.

    @cscott
    cscott committed Oct 20, 2015
    Configuration menu
    Copy the full SHA
    a708655 View commit details
    Browse the repository at this point in the history

  6. Listen for SIGABRT in addition to SIGSEGV. 

    Our OSX builds seem to crash with SIGABRT.
    @cscott
    cscott committed Oct 20, 2015
    Configuration menu
    Copy the full SHA
    77b711e View commit details
    Browse the repository at this point in the history

  7. Fix startup crash.

    @cscott
    cscott committed Oct 20, 2015
    Configuration menu
    Copy the full SHA
    e420aad View commit details
    Browse the repository at this point in the history

  8. Limit supported configurations to node >= 1.8.4. 

    We use C++11 features, which older versions of node do not support.
    @cscott
    cscott committed Oct 20, 2015
    Configuration menu
    Copy the full SHA
    d4ca314 View commit details
    Browse the repository at this point in the history

  9. Allow using a Map instead of a WeakMap for older node versions.

    @cscott
    cscott committed Oct 20, 2015
    Configuration menu
    Copy the full SHA
    4006cd7 View commit details
    Browse the repository at this point in the history

  10. WIP: node 1.8.4 support 

    Turns out that using Map instead of NativeWeakMap isn't a solution
for node 1.8.4, since it doesn't export Map either.  Sigh.

We can hack up our own NativeWeakMap using hidden properties, as
shown by this WIP patch, but I don't think it's worth it.  Let's
just not support node <= 1.8.4.
    @cscott
    cscott committed Oct 20, 2015
    Configuration menu
    Copy the full SHA
    675dcd4 View commit details
    Browse the repository at this point in the history
Loading