Enhancements

Author: sachinites

multiply.c

@@ -7,41 +7,12 @@
 #include "rpc_common.h"
 #include "De_Serialization/serialize.h"
 
-int
-rpc_send_recv (ser_buff_t *client_send_ser_buffer, 
-               ser_buff_t *client_recv_ser_buffer){
-
-    struct sockaddr_in dest;
-    int sockfd = 0, rc = 0, recv_size = 0;
-    int addr_len;
-
-    dest.sin_family = AF_INET;
-    dest.sin_port = htons(SERVER_PORT);
-    struct hostent *host = (struct hostent *)gethostbyname(SERVER_IP);
-    dest.sin_addr = *((struct in_addr *)host->h_addr);
-    addr_len = sizeof(struct sockaddr);
-
-    sockfd = socket(AF_INET, SOCK_DGRAM, IPPROTO_UDP);
-    if(sockfd == -1){
-        printf("socket creation failed\n");
-        return -1;
-    }
-
-    rc = sendto(sockfd, client_send_ser_buffer->b, 
-                get_serialize_buffer_length(client_send_ser_buffer), 
-                0, (struct sockaddr *)&dest, sizeof(struct sockaddr));
-
-    printf("%s() : %d bytes sent\n", __FUNCTION__, rc);
-
-    recv_size = recvfrom(sockfd, client_recv_ser_buffer->b, 
-                get_serialize_buffer_length(client_recv_ser_buffer), 0,
-                (struct sockaddr *)&dest, &addr_len);
-
-    printf("%s() : %d bytes recieved\n", __FUNCTION__, recv_size);
-
-    return recv_size;
+void
+rpc_send_recv (ser_buff_t *client_send_ser_buffer,
+        ser_buff_t *client_recv_ser_buffer){
 }
 
+
 /* client_stub_marshal()*/
 ser_buff_t *
 multiply_client_stub_marshal(int a, int b){
@@ -54,38 +25,21 @@ multiply_client_stub_marshal(int a, int b){
     /*Serialize the second Argument*/
     serialize_data(client_send_ser_buffer, (char *)&b, sizeof(int));
 
-    /*Serialize buffer looks like this 
-     *
-     *  +---------+---------+
-     *  |         |         |
-     *  |   Arg1  |   Arg2  |
-     *  +---------+---------+
-     *  <----4----><----4--->
+    /*Serialize buffer looks like this
+     * 
+     * +---------+---------+
+     * |         |         |
+     * |   Arg1  |   Arg2  |
+     * +---------+---------+
+     * <----4----><----4--->
      * */
     return client_send_ser_buffer;
 }
 
-int multiply_client_stub_unmarshal(ser_buff_t *client_recv_ser_buffer){
-
-    /*Reconstruct the result obtained from Server*/
-    int res = 0;
-    de_serialize_data((char *)&res, client_recv_ser_buffer, sizeof(int));
-    return res;
-}
-
-void 
-init_rpc_infra(){
-
-    /*Initialize anything before starting RPC , if any*/    
-}
-
 
 int
 multiply_rpc(int a , int b){
 
-    /*init RPC buffers*/
-    init_rpc_infra();
-
     /*Step 2 : Serialize/Marshal the arguments*/
     /*Signature :  ser_buff_t* (client_stub_marshal) <Arg1, Arg2, . . . ,> */
     ser_buff_t *client_send_ser_buffer = multiply_client_stub_marshal(a, b);
@@ -108,19 +62,6 @@ multiply_rpc(int a , int b){
      client_send_ser_buffer = NULL;
 
     /*Step 4 , 5, 6 , 7, 8 are executed on Server side*/
-
-    /*Step 9 : Unmarshal the serialized data (result) recvd from Server,
-     * and reconsctruct the RPC return type
-     * Signature : <rpc return type> (client_stub_unmarshal) <ser_buff_t *>
-     * */
-     
-    int res = multiply_client_stub_unmarshal(client_recv_ser_buffer);
-
-    /*Client has successfully reconstructed the result object from
-     * serialized data recvd from Server, Time to free client_recv_ser_buffer*/
-
-    free_serialize_buffer(client_recv_ser_buffer);
-    return res;
 }
 
 int

rpc_server_main.c

@@ -23,12 +23,6 @@ multiply_server_stub_unmarshal(ser_buff_t *server_recv_ser_buffer){
     return multiply(a, b);
 }
 
-void
-multiply_server_stub_marshal(int res, ser_buff_t *server_send_ser_buffer){
-
-    serialize_data(server_send_ser_buffer, (char *)&res, sizeof(int));
-}
-
 void
 rpc_server_process_msg(ser_buff_t *server_recv_ser_buffer, 
                        ser_buff_t *server_send_ser_buffer){
@@ -40,8 +34,6 @@ rpc_server_process_msg(ser_buff_t *server_recv_ser_buffer,
 
    int res = multiply_server_stub_unmarshal(server_recv_ser_buffer); 
 
-   /*Step 7 : Now we have got the RPC result, time to serialize/Marshall the result*/
-   multiply_server_stub_marshal(res, server_send_ser_buffer);
 }
 
 int
@@ -109,12 +101,6 @@ main(int argc, char **argv){
 	rpc_server_process_msg(server_recv_ser_buffer, /*Serialized Data which came from client*/
                            server_send_ser_buffer); /*Empty serialized buffer*/
 
-    /*Step 8 : Send the serialized result data back to client*/
-	len = sendto(sock_udp_fd, server_send_ser_buffer->b, 
-                 get_serialize_buffer_data_size(server_send_ser_buffer),
-                 0, (struct sockaddr *)&client_addr, sizeof(struct sockaddr));
-
-	printf("rpc server replied with %d bytes msg\n", len);
 	goto READ;
 	return 0;
 }