Commentary on constructing an Observable

- I would like to remove the no-arg constructor but not ready to pull the trigger

Author: benjchristensen

rxjava-core/src/main/java/rx/Observable.java

@@ -116,14 +116,10 @@ public class Observable<T> {
 
     private final Func1<Observer<T>, Subscription> onSubscribe;
 
-    protected Observable() {
-        this(null);
-    }
-
     /**
-     * Construct an Observable with Function to execute when subscribed to.
+     * Observable with Function to execute when subscribed to.
      * <p>
-     * NOTE: Generally you're better off using {@link #create(Func1)} to create an Observable instead of using inheritance.
+     * NOTE: Use {@link #create(Func1)} to create an Observable instead of this method unless you specifically have a need for inheritance.
      * 
      * @param onSubscribe
      *            {@link Func1} to be executed when {@link #subscribe(Observer)} is called.
@@ -132,6 +128,11 @@ protected Observable(Func1<Observer<T>, Subscription> onSubscribe) {
         this.onSubscribe = onSubscribe;
     }
 
+    protected Observable() {
+        this(null);
+        //TODO should this be made private to prevent it? It really serves no good purpose and only confuses things. Unit tests are incorrectly using it today
+    }
+
     /**
      * an {@link Observer} must call an Observable's <code>subscribe</code> method in order to register itself
      * to receive push-based notifications from the Observable. A typical implementation of the