Skip to content

Commit 5e8ba12

Browse files
committed
minor clean up
1 parent 335c52a commit 5e8ba12

File tree

1 file changed

+13
-12
lines changed

1 file changed

+13
-12
lines changed

client/src/test/java/org/asynchttpclient/netty/NettyResponseFutureTest.java

Lines changed: 13 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@ public class NettyResponseFutureTest {
1414

1515
@Test
1616
public void testCancel() {
17-
AsyncHandler asyncHandler = mock(AsyncHandler.class);
18-
NettyResponseFuture nettyResponseFuture = new NettyResponseFuture<>(null, asyncHandler, null, 3, null, null);
17+
AsyncHandler<?> asyncHandler = mock(AsyncHandler.class);
18+
NettyResponseFuture<?> nettyResponseFuture = new NettyResponseFuture<>(null, asyncHandler, null, 3, null, null);
1919
boolean result = nettyResponseFuture.cancel(false);
2020
verify(asyncHandler).onThrowable(anyObject());
2121
assertTrue(result, "Cancel should return true if the Future was cancelled successfully");
@@ -24,8 +24,8 @@ public void testCancel() {
2424

2525
@Test
2626
public void testCancelOnAlreadyCancelled() {
27-
AsyncHandler asyncHandler = mock(AsyncHandler.class);
28-
NettyResponseFuture nettyResponseFuture = new NettyResponseFuture<>(null, asyncHandler, null, 3, null, null);
27+
AsyncHandler<?> asyncHandler = mock(AsyncHandler.class);
28+
NettyResponseFuture<?> nettyResponseFuture = new NettyResponseFuture<>(null, asyncHandler, null, 3, null, null);
2929
nettyResponseFuture.cancel(false);
3030
boolean result = nettyResponseFuture.cancel(false);
3131
assertFalse(result, "cancel should return false for an already cancelled Future");
@@ -34,38 +34,39 @@ public void testCancelOnAlreadyCancelled() {
3434

3535
@Test(expectedExceptions = CancellationException.class)
3636
public void testGetContentThrowsCancellationExceptionIfCancelled() throws InterruptedException, ExecutionException {
37-
AsyncHandler asyncHandler = mock(AsyncHandler.class);
38-
NettyResponseFuture nettyResponseFuture = new NettyResponseFuture<>(null, asyncHandler, null, 3, null, null);
37+
AsyncHandler<?> asyncHandler = mock(AsyncHandler.class);
38+
NettyResponseFuture<?> nettyResponseFuture = new NettyResponseFuture<>(null, asyncHandler, null, 3, null, null);
3939
nettyResponseFuture.cancel(false);
4040
nettyResponseFuture.get();
4141
fail("A CancellationException must have occurred by now as 'cancel' was called before 'get'");
4242
}
4343

4444
@Test
4545
public void testGet() throws Exception {
46-
AsyncHandler asyncHandler = mock(AsyncHandler.class);
46+
@SuppressWarnings("unchecked")
47+
AsyncHandler<Object> asyncHandler = mock(AsyncHandler.class);
4748
Object value = new Object();
4849
when(asyncHandler.onCompleted()).thenReturn(value);
49-
NettyResponseFuture nettyResponseFuture = new NettyResponseFuture<>(null, asyncHandler, null, 3, null, null);
50+
NettyResponseFuture<?> nettyResponseFuture = new NettyResponseFuture<>(null, asyncHandler, null, 3, null, null);
5051
nettyResponseFuture.done();
5152
Object result = nettyResponseFuture.get();
5253
assertEquals(result, value, "The Future should return the value given by asyncHandler#onCompleted");
5354
}
5455

5556
@Test(expectedExceptions = ExecutionException.class)
5657
public void testGetThrowsExceptionThrownByAsyncHandler() throws Exception {
57-
AsyncHandler asyncHandler = mock(AsyncHandler.class);
58+
AsyncHandler<?> asyncHandler = mock(AsyncHandler.class);
5859
when(asyncHandler.onCompleted()).thenThrow(new RuntimeException());
59-
NettyResponseFuture nettyResponseFuture = new NettyResponseFuture<>(null, asyncHandler, null, 3, null, null);
60+
NettyResponseFuture<?> nettyResponseFuture = new NettyResponseFuture<>(null, asyncHandler, null, 3, null, null);
6061
nettyResponseFuture.done();
6162
nettyResponseFuture.get();
6263
fail("An ExecutionException must have occurred by now as asyncHandler threw an exception in 'onCompleted'");
6364
}
6465

6566
@Test(expectedExceptions = ExecutionException.class)
6667
public void testGetThrowsExceptionOnAbort() throws InterruptedException, ExecutionException {
67-
AsyncHandler asyncHandler = mock(AsyncHandler.class);
68-
NettyResponseFuture nettyResponseFuture = new NettyResponseFuture<>(null, asyncHandler, null, 3, null, null);
68+
AsyncHandler<?> asyncHandler = mock(AsyncHandler.class);
69+
NettyResponseFuture<?> nettyResponseFuture = new NettyResponseFuture<>(null, asyncHandler, null, 3, null, null);
6970
nettyResponseFuture.abort(new RuntimeException());
7071
nettyResponseFuture.get();
7172
fail("An ExecutionException must have occurred by now as 'abort' was called before 'get'");

0 commit comments

Comments
 (0)