Skip to content

Commit eb1fbea

Browse files
committed
Use Netty's constants
1 parent 96ad5ef commit eb1fbea

File tree

2 files changed

+4
-12
lines changed

2 files changed

+4
-12
lines changed

client/src/main/java/org/asynchttpclient/request/body/multipart/FileLikePart.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
package org.asynchttpclient.request.body.multipart;
1414

1515
import static org.asynchttpclient.util.MiscUtils.withDefault;
16+
import static io.netty.handler.codec.http.HttpHeaders.Values.*;
1617

1718
import java.nio.charset.Charset;
1819

@@ -26,11 +27,6 @@ public abstract class FileLikePart extends PartBase {
2627
*/
2728
public static final String DEFAULT_CONTENT_TYPE = "application/octet-stream";
2829

29-
/**
30-
* Default transfer encoding of file attachments.
31-
*/
32-
public static final String DEFAULT_TRANSFER_ENCODING = "binary";
33-
3430
private String fileName;
3531

3632
/**
@@ -47,7 +43,7 @@ public FileLikePart(String name, String contentType, Charset charset, String con
4743
withDefault(contentType, DEFAULT_CONTENT_TYPE),//
4844
charset,//
4945
contentId,//
50-
withDefault(transfertEncoding, DEFAULT_TRANSFER_ENCODING));
46+
withDefault(transfertEncoding, BINARY));
5147
}
5248

5349
public final void setFileName(String fileName) {

client/src/main/java/org/asynchttpclient/request/body/multipart/MultipartUtils.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
package org.asynchttpclient.request.body.multipart;
1515

1616
import static java.nio.charset.StandardCharsets.US_ASCII;
17+
import static io.netty.handler.codec.http.HttpHeaders.Values.*;
1718
import static org.asynchttpclient.util.Assertions.assertNotNull;
1819
import static org.asynchttpclient.util.MiscUtils.isNonEmpty;
1920
import io.netty.handler.codec.http.HttpHeaders;
@@ -30,11 +31,6 @@
3031

3132
public class MultipartUtils {
3233

33-
/**
34-
* The Content-Type for multipart/form-data.
35-
*/
36-
private static final String MULTIPART_FORM_CONTENT_TYPE = "multipart/form-data";
37-
3834
/**
3935
* The pool of ASCII chars to be used for generating a multipart boundary.
4036
*/
@@ -67,7 +63,7 @@ public static MultipartBody newMultipartBody(List<Part> parts, HttpHeaders reque
6763
}
6864
} else {
6965
boundary = generateBoundary();
70-
contentType = computeContentType(MULTIPART_FORM_CONTENT_TYPE, boundary);
66+
contentType = computeContentType(MULTIPART_FORM_DATA, boundary);
7167
}
7268

7369
List<MultipartPart<? extends Part>> multipartParts = generateMultipartParts(parts, boundary);

0 commit comments

Comments
 (0)