Do not use empty()

Author: sebastianbergmann

src/CodeCoverage.php

@@ -252,7 +252,7 @@ public function append(RawCodeCoverageData $rawData, ?string $id = null, bool $a
             $size,
         );
 
-        if (empty($rawData->lineCoverage())) {
+        if ($rawData->lineCoverage() === []) {
             return;
         }
 
@@ -395,7 +395,7 @@ private function applyCoversAndUsesFilter(RawCodeCoverageData $rawData, array|fa
             return;
         }
 
-        if (empty($linesToBeCovered)) {
+        if ($linesToBeCovered === []) {
             return;
         }
 
@@ -513,7 +513,7 @@ private function performUnintentionallyCoveredCodeCheck(RawCodeCoverageData $dat
 
         $unintentionallyCoveredUnits = $this->processUnintentionallyCoveredUnits($unintentionallyCoveredUnits);
 
-        if (!empty($unintentionallyCoveredUnits)) {
+        if ($unintentionallyCoveredUnits === []) {
             throw new UnintentionallyCoveredCodeException(
                 $unintentionallyCoveredUnits,
             );

src/Data/RawCodeCoverageData.php

@@ -214,7 +214,7 @@ public function keepFunctionCoverageDataOnlyForLines(string $filename, array $li
      */
     public function removeCoverageDataForLines(string $filename, array $lines): void
     {
-        if (empty($lines)) {
+        if ($lines === []) {
             return;
         }
 

src/Filter.php

@@ -88,6 +88,6 @@ public function files(): array
 
     public function isEmpty(): bool
     {
-        return empty($this->files);
+        return $this->files === [];
     }
 }

src/Node/Builder.php

@@ -201,7 +201,7 @@ private function buildDirectoryStructure(ProcessedCodeCoverageData $data): array
      */
     private function reducePaths(ProcessedCodeCoverageData $coverage): string
     {
-        if (empty($coverage->coveredFiles())) {
+        if ($coverage->coveredFiles() === []) {
             return '.';
         }
 
@@ -226,7 +226,7 @@ private function reducePaths(ProcessedCodeCoverageData $coverage): string
 
             $paths[$i] = explode(DIRECTORY_SEPARATOR, $paths[$i]);
 
-            if (empty($paths[$i][0])) {
+            if ($paths[$i][0] === '') {
                 $paths[$i][0] = DIRECTORY_SEPARATOR;
             }
         }

src/Report/Crap4j.php

@@ -83,7 +83,7 @@ public function process(CodeCoverage $coverage, ?string $target = null, ?string
 
                     $methodNode = $document->createElement('method');
 
-                    if (!empty($class['namespace'])) {
+                    if ($class['namespace'] !== '') {
                         $namespace = $class['namespace'];
                     }
 

src/Report/Html/Renderer/File.php

@@ -332,7 +332,7 @@ private function renderTraitOrClassItems(array $items, Template $template, Templ
     {
         $buffer = '';
 
-        if (empty($items)) {
+        if ($items === []) {
             return $buffer;
         }
 
@@ -437,7 +437,7 @@ private function renderTraitOrClassItems(array $items, Template $template, Templ
      */
     private function renderFunctionItems(array $functions, Template $template): string
     {
-        if (empty($functions)) {
+        if ($functions === []) {
             return '';
         }
 
@@ -570,7 +570,7 @@ private function renderSourceWithLineCoverage(FileNode $node): string
 
             $popover = '';
 
-            if (!empty($popoverTitle)) {
+            if ($popoverTitle !== '') {
                 $popover = sprintf(
                     ' data-bs-title="%s" data-bs-content="%s" data-bs-placement="top" data-bs-html="true"',
                     $popoverTitle,
@@ -848,7 +848,7 @@ private function renderBranchLines(array $branch, array $codeLines, array $testD
 
             $popover = '';
 
-            if (!empty($popoverTitle)) {
+            if ($popoverTitle !== '') {
                 $popover = sprintf(
                     ' data-bs-title="%s" data-bs-content="%s" data-bs-placement="top" data-bs-html="true"',
                     $popoverTitle,
@@ -966,7 +966,7 @@ private function renderPathLines(array $path, array $branches, array $codeLines,
 
                 $popover = '';
 
-                if (!empty($popoverTitle)) {
+                if ($popoverTitle !== '') {
                     $popover = sprintf(
                         ' data-bs-title="%s" data-bs-content="%s" data-bs-placement="top" data-bs-html="true"',
                         $popoverTitle,

src/Report/Text.php

@@ -60,7 +60,7 @@ public function __construct(Thresholds $thresholds, bool $showUncoveredFiles = f
 
     public function process(CodeCoverage $coverage, bool $showColors = false): string
     {
-        $hasBranchCoverage = !empty($coverage->getData(true)->functionCoverage());
+        $hasBranchCoverage = $coverage->getData(true)->functionCoverage() !== [];
 
         $output = PHP_EOL . PHP_EOL;
         $report = $coverage->getReport();

src/StaticAnalysis/CodeUnitFindingVisitor.php

@@ -117,7 +117,7 @@ public function leaveNode(Node $node): null
             }
         }
 
-        if (empty($traits)) {
+        if ($traits === []) {
             return null;
         }
 

src/StaticAnalysis/ParsingFileAnalyser.php

@@ -160,7 +160,7 @@ private function analyse(string $filename): void
         $source      = file_get_contents($filename);
         $linesOfCode = max(substr_count($source, "\n") + 1, substr_count($source, "\r") + 1);
 
-        if ($linesOfCode === 0 && !empty($source)) {
+        if ($linesOfCode === 0 && $source !== false && $source !== '') {
             $linesOfCode = 1;
         }