Disable SSlv2ClientHello by default, close AsyncHttpClient#934

Author: slandelle

src/main/java/com/ning/http/client/AsyncHttpClientConfig.java

@@ -506,7 +506,7 @@ public static class Builder {
         private int maxRequestRetry = defaultMaxRequestRetry();
         private boolean disableUrlEncodingForBoundedRequests = defaultDisableUrlEncodingForBoundRequests();
         private int ioThreadMultiplier = defaultIoThreadMultiplier();
-        private String[] enabledProtocols;
+        private String[] enabledProtocols = defaultEnabledProtocols();
         private String[] enabledCipherSuites;
         private Integer sslSessionCacheSize = defaultSslSessionCacheSize();
         private Integer sslSessionTimeout = defaultSslSessionTimeout();

src/main/java/com/ning/http/client/AsyncHttpClientConfigDefaults.java

@@ -108,12 +108,16 @@ public static boolean defaultDisableUrlEncodingForBoundRequests() {
     public static boolean defaultAcceptAnyCertificate() {
         return getBoolean(ASYNC_CLIENT + "acceptAnyCertificate", false);
     }
-    
+
     public static Integer defaultSslSessionCacheSize() {
         return Integer.getInteger(ASYNC_CLIENT + "sslSessionCacheSize");
     }
 
     public static Integer defaultSslSessionTimeout() {
         return Integer.getInteger(ASYNC_CLIENT + "sslSessionTimeout");
     }
+
+    public static String[] defaultEnabledProtocols() {
+        return new String[] { "TLSv1.2", "TLSv1.1", "TLSv1" };
+    }
 }

src/main/java/com/ning/http/client/SSLEngineFactory.java

@@ -13,6 +13,8 @@
  */
 package com.ning.http.client;
 
+import static com.ning.http.util.MiscUtils.isNonEmpty;
+
 import com.ning.http.util.SslUtils;
 
 import javax.net.ssl.SSLContext;
@@ -54,10 +56,10 @@ public SSLEngine newSSLEngine(String peerHost, int peerPort) throws GeneralSecur
             }
             sslEngine.setUseClientMode(true);
 
-            if (config.getEnabledProtocols() != null)
+            if (isNonEmpty(config.getEnabledProtocols()))
                 sslEngine.setEnabledProtocols(config.getEnabledProtocols());
 
-            if (config.getEnabledCipherSuites() != null)
+            if (isNonEmpty(config.getEnabledCipherSuites()))
                 sslEngine.setEnabledCipherSuites(config.getEnabledCipherSuites());
 
             return sslEngine;