chore: fix lint github action (GoogleCloudPlatform#1925)

* use files changed github action

* fix yaml syntax

* use files instead of dirs

* testing modifying a file

* debug info

* format files changed correctly

* Revert "testing modifying a file"

This reverts commit 22da5ea.

* get rid of skipped dir (redundant)

Author: bshaffer

.github/workflows/lint.yml

@@ -22,13 +22,13 @@ jobs:
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v4
-      with:
-        ref: ${{ github.event.pull_request.head.ref }}
-        fetch-depth: 5
     - name: Install PHP
       uses: shivammathur/setup-php@v2
       with:
         php-version: '8.0'
+    - name: Get changed files
+      id: changedFiles
+      uses: tj-actions/changed-files@v39
     - uses: jwalton/gh-find-current-pr@v1
       id: findPr
       with:
@@ -39,5 +39,5 @@ jobs:
         git fetch --no-tags --prune --depth=5 origin main
         bash testing/run_staticanalysis_check.sh
       env:
-        PULL_REQUEST_NUMBER: ${{ steps.findPr.outputs.pr }}
-
+        FILES_CHANGED: ${{ steps.changedFiles.outputs.all_changed_files }}
+        PULL_REQUEST_NUMBER: ${{ steps.findPr.outputs.pr }}

testing/run_staticanalysis_check.sh

@@ -17,10 +17,6 @@ if [ "${BASH_DEBUG}" = "true" ]; then
     set -x
 fi
 
-if [ "${TEST_DIRECTORIES}" = "" ]; then
-  TEST_DIRECTORIES="*"
-fi
-
 SKIP_DIRS=(
   dialogflow
   iot
@@ -29,11 +25,15 @@ SKIP_DIRS=(
 TMP_REPORT_DIR=$(mktemp -d)
 SUCCEEDED_FILE=${TMP_REPORT_DIR}/succeeded
 FAILED_FILE=${TMP_REPORT_DIR}/failed
-SKIPPED_FILE=${TMP_REPORT_DIR}/skipped
 
-# Determine all files changed on this branch
-# (will be empty if running from "main").
-FILES_CHANGED=$(git diff --name-only HEAD origin/main)
+if [ "${TEST_DIRECTORIES}" = "" ]; then
+  TEST_DIRECTORIES="*"
+fi
+
+if [ "${FILES_CHANGED}" = "" ]; then
+  FILES_CHANGED=""
+fi
+FILES_CHANGED=$(echo $FILES_CHANGED | tr " " "\n")
 
 # If the label `kokoro:run-all` is added, or if we were not triggered from a Pull
 # Request, run the whole test suite.
@@ -56,13 +56,11 @@ do
     if [ "$RUN_ALL_TESTS" -ne "1" ]; then
         if ! grep -q ^$dir <<< "$FILES_CHANGED" ; then
             echo "Skipping tests in $dir (unchanged)"
-            echo "$dir: skipped" >> "${SKIPPED_FILE}"
             continue
         fi
     fi
     if [[ " ${SKIP_DIRS[@]} " =~ " ${dir} " ]]; then
         printf "Skipping $dir (explicitly flagged to be skipped)\n\n"
-        echo "$dir: skipped" >> "${SKIPPED_FILE}"
         continue
     fi
     composer update --working-dir=$dir --ignore-platform-reqs -q
@@ -90,13 +88,6 @@ if [ -f "${SUCCEEDED_FILE}" ]; then
     echo "-------------------------------"
 fi
 
-if [ -f "${SKIPPED_FILE}" ]; then
-    echo "--------- SKIPPED --------------"
-    cat "${SKIPPED_FILE}"
-    echo "--------------------------------"
-    # Report any skips
-fi
-
 if [ -f "${FAILED_FILE}" ]; then
     echo "--------- Failed --------------"
     cat "${FAILED_FILE}"