fix(progress bar): solved problem with negative number of requests

Author: Ismaestro

src/app/shared/services/progress-bar.service.spec.ts

@@ -29,14 +29,24 @@ describe('ProgressBarService', () => {
     heroService = TestBed.get(HeroService);
   });
 
-  it('should not be requestsRunning', (() => {
+  fit('should not be requestsRunning', (() => {
+    const instance = new ProgressBarService(heroService);
+    expect(instance).toBeTruthy();
+  }));
+
+  fit('should not be requestsRunning', (() => {
     expect(progressBarService.requestsRunning).toBe(0);
   }));
 
-  it('should increase and decrease the counter of requests running', (() => {
+  fit('should increase and decrease the counter of requests running', (() => {
+    heroService.request$.emit('starting');
     heroService.request$.emit('starting');
+    expect(progressBarService.requestsRunning).toBe(2);
+    heroService.request$.emit('finished');
     expect(progressBarService.requestsRunning).toBe(1);
     heroService.request$.emit('finished');
     expect(progressBarService.requestsRunning).toBe(0);
+    heroService.request$.emit('finished');
+    expect(progressBarService.requestsRunning).toBe(0);
   }));
 });

src/app/shared/services/progress-bar.service.ts

@@ -16,7 +16,7 @@ export class ProgressBarService {
         if (this.requestsRunning === 1) {
           this.updateProgressBar$.emit('query');
         }
-      } else if (this.requestsRunning >= 0) {
+      } else if (this.requestsRunning > 0) {
         this.requestsRunning--;
         if (this.requestsRunning === 0) {
           this.updateProgressBar$.emit('none');