Skip to content

Commit 23786aa

Browse files
vicbmhevery
authored andcommitted
feat(DomAdapter): add types
Closes angular#842
1 parent 749a758 commit 23786aa

File tree

4 files changed

+21
-21
lines changed

4 files changed

+21
-21
lines changed

modules/angular2/src/dom/browser_adapter.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -188,8 +188,8 @@ class BrowserDomAdapter extends DomAdapter {
188188
Node importIntoDoc(Node node) {
189189
return document.importNode(node, true);
190190
}
191-
isPageRule(CssRule rule) => rule is CssPageRule;
192-
isStyleRule(CssRule rule) => rule is CssStyleRule;
193-
isMediaRule(CssRule rule) => rule is CssMediaRule;
194-
isKeyframesRule(CssRule rule) => rule is CssKeyframesRule;
191+
bool isPageRule(CssRule rule) => rule is CssPageRule;
192+
bool isStyleRule(CssRule rule) => rule is CssStyleRule;
193+
bool isMediaRule(CssRule rule) => rule is CssMediaRule;
194+
bool isKeyframesRule(CssRule rule) => rule is CssKeyframesRule;
195195
}

modules/angular2/src/dom/browser_adapter.es6

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export class BrowserDomAdapter extends DomAdapter {
1717
return _attrToPropMap;
1818
}
1919

20-
query(selector) {
20+
query(selector:string) {
2121
return document.querySelector(selector);
2222
}
2323
querySelector(el, selector:string):Node {
@@ -246,16 +246,16 @@ export class BrowserDomAdapter extends DomAdapter {
246246
}
247247
return result;
248248
}
249-
isPageRule(rule) {
249+
isPageRule(rule): boolean {
250250
return rule.type === CSSRule.PAGE_RULE;
251251
}
252-
isStyleRule(rule) {
252+
isStyleRule(rule): boolean {
253253
return rule.type === CSSRule.STYLE_RULE;
254254
}
255-
isMediaRule(rule) {
255+
isMediaRule(rule): boolean {
256256
return rule.type === CSSRule.MEDIA_RULE;
257257
}
258-
isKeyframesRule(rule) {
258+
isKeyframesRule(rule): boolean {
259259
return rule.type === CSSRule.KEYFRAMES_RULE;
260260
}
261261
}

modules/angular2/src/dom/dom_adapter.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export class DomAdapter {
2727
parse(templateHtml:string) {
2828
throw _abstract();
2929
}
30-
query(selector) {
30+
query(selector:string) {
3131
throw _abstract();
3232
}
3333
querySelector(el, selector:string) {
@@ -222,16 +222,16 @@ export class DomAdapter {
222222
importIntoDoc(node) {
223223
throw _abstract();
224224
}
225-
isPageRule(rule) {
225+
isPageRule(rule): boolean {
226226
throw _abstract();
227227
}
228-
isStyleRule(rule) {
228+
isStyleRule(rule): boolean {
229229
throw _abstract();
230230
}
231-
isMediaRule(rule) {
231+
isMediaRule(rule): boolean {
232232
throw _abstract();
233233
}
234-
isKeyframesRule(rule) {
234+
isKeyframesRule(rule): boolean {
235235
throw _abstract();
236236
}
237237
}

modules/angular2/src/dom/html5lib_adapter.dart

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ class Html5LibDomAdapter implements DomAdapter {
4949
content(TemplateElement node) {
5050
throw 'not implemented';
5151
}
52-
52+
5353
firstChild(el) => el is NodeList
5454
? el.first
5555
: el.firstChild;
@@ -166,7 +166,7 @@ class Html5LibDomAdapter implements DomAdapter {
166166
getStyle(element, String stylename) {
167167
throw 'not implemented';
168168
}
169-
169+
170170
String tagName(element) => element.localName;
171171

172172
attributeMap(element) => element.attributes;
@@ -205,7 +205,7 @@ class Html5LibDomAdapter implements DomAdapter {
205205
bool isCommentNode(node) {
206206
throw 'not implemented';
207207
}
208-
208+
209209
bool isElementNode(node) => node is Element;
210210

211211
bool hasShadowRoot(node) {
@@ -214,16 +214,16 @@ class Html5LibDomAdapter implements DomAdapter {
214214
importIntoDoc(node) {
215215
throw 'not implemented';
216216
}
217-
isPageRule(rule) {
217+
bool isPageRule(rule) {
218218
throw 'not implemented';
219219
}
220-
isStyleRule(rule) {
220+
bool isStyleRule(rule) {
221221
throw 'not implemented';
222222
}
223-
isMediaRule(rule) {
223+
bool isMediaRule(rule) {
224224
throw 'not implemented';
225225
}
226-
isKeyframesRule(rule) {
226+
bool isKeyframesRule(rule) {
227227
throw 'not implemented';
228228
}
229229
}

0 commit comments

Comments
 (0)