Code cleanup

Author: mairbek

rxjava-core/src/main/java/rx/Observable.java

@@ -131,7 +131,7 @@ public Subscription subscribe(Observer<T> observer) {
             AtomicObservableSubscription subscription = new AtomicObservableSubscription();
             return subscription.wrap(onSubscribe.call(new AtomicObserver<T>(subscription, observer)));
         }
-    };
+    }
 
     @SuppressWarnings({ "rawtypes", "unchecked" })
     public Subscription subscribe(final Map<String, Object> callbacks) {

rxjava-core/src/main/java/rx/operators/OperationFilter.java

@@ -48,7 +48,7 @@ public Subscription call(final Observer<T> observer) {
             return subscription.wrap(that.subscribe(new Observer<T>() {
                 public void onNext(T value) {
                     try {
-                        if ((boolean) predicate.call(value)) {
+                        if (predicate.call(value)) {
                             observer.onNext(value);
                         }
                     } catch (Exception ex) {
@@ -79,10 +79,7 @@ public void testFilter() {
 
                 @Override
                 public Boolean call(String t1) {
-                    if (t1.equals("two"))
-                        return true;
-                    else
-                        return false;
+                    return t1.equals("two");
                 }
             }));
 

rxjava-core/src/main/java/rx/operators/OperationZip.java

@@ -260,9 +260,7 @@ private void stop() {
             if (running.compareAndSet(true, false)) {
                 /* propogate to all Observers to unsubscribe if this thread succeeded in setting running=false */
                 for (ZipObserver<T, ?> rw : observers) {
-                    if (rw.subscription != null) {
-                        rw.subscription.unsubscribe();
-                    }
+                    rw.subscription.unsubscribe();
                 }
             }
         }

rxjava-core/src/main/java/rx/subjects/Subject.java

@@ -76,7 +76,7 @@ public void onNext(T args) {
     public static class UnitTest {
         @Test
         public void test() {
-            Subject<Integer> subject = Subject.<Integer> create();
+            Subject<Integer> subject = Subject.create();
             final AtomicReference<List<Notification<String>>> actualRef = new AtomicReference<List<Notification<String>>>();
 
             Observable<List<Notification<Integer>>> wNotificationsList = subject.materialize().toList();

rxjava-core/src/main/java/rx/util/SynchronizedObserver.java

@@ -373,7 +373,7 @@ public void run() {
         }
 
         private static enum TestConcurrencyObserverEvent {
-            onCompleted, onError, onNext;
+            onCompleted, onError, onNext
         }
 
         private static class TestConcurrencyObserver implements Observer<String> {