Minor instance access changes for TDD test

Author: RicardoDiffBlue

src/main/java/com/diffblue/corebanking/account/Account.java

@@ -187,8 +187,6 @@ public String toString() {
     return output;
   }
 
-  public void foo() {}
-
   /** AccountState. */
   public enum AccountState {
     OPEN,
@@ -209,7 +207,7 @@ private AccountStatement() {
      *
      * @return The transactions list.
      */
-    private List<Transaction> getTransactions() {
+    public List<Transaction> getTransactions() {
       return transactions;
     }
 
@@ -239,5 +237,6 @@ public String toString() {
 
       return output;
     }
+
   }
 }

src/main/java/com/diffblue/corebanking/compliance/CheckCompliance.java

@@ -8,7 +8,7 @@
 
 public class CheckCompliance {
 
-  private static final List<ComplianceRule> COMPLIANCE_RULES = new ArrayList<ComplianceRule>();
+  public static final List<ComplianceRule> COMPLIANCE_RULES = new ArrayList<ComplianceRule>();
 
   static {
     COMPLIANCE_RULES.add(new ComplianceRuleBalanceAboveOrEqualToZero());

src/main/java/com/diffblue/corebanking/compliance/rules/ComplianceRule.java

@@ -8,23 +8,13 @@ public abstract class ComplianceRule {
 
   protected final List<Account> currentFailedAccounts = new ArrayList<Account>();
   protected final List<Account> currentPassedAccounts = new ArrayList<Account>();
-  private final int ruleID;
-
-  /**
-   * Constructor.
-   *
-   * @param ruleID The ID of the rule instance.
-   */
-  protected ComplianceRule(int ruleID) {
-    this.ruleID = ruleID;
-  }
 
   /**
    * Checks if the passed account passes or fails this rule.
    *
    * @param account The account to verify compliance.
    */
-  public abstract void ValidateAccountCompliance(Account account);
+  public abstract boolean ValidateAccountCompliance(Account account);
 
   /** Purges all accounts from the rules. */
   public void purgeAccounts() {

src/main/java/com/diffblue/corebanking/compliance/rules/ComplianceRuleBalanceAboveOrEqualToZero.java

@@ -4,19 +4,12 @@
 
 public class ComplianceRuleBalanceAboveOrEqualToZero extends ComplianceRule {
 
-  private static final int RULE_ID = 1;
-
-  /** Constructor. */
-  public ComplianceRuleBalanceAboveOrEqualToZero() {
-    super(RULE_ID);
-  }
-
   /**
    * Checks if the passed account passes or fails this rule.
    *
    * @param account The account to verify compliance.
    */
-  public void ValidateAccountCompliance(Account account) {
+  public boolean ValidateAccountCompliance(Account account) {
 
     // Make sure the account does not belong to any list.
     currentFailedAccounts.remove(account);
@@ -25,8 +18,10 @@ public void ValidateAccountCompliance(Account account) {
     // Check if this account passes or fails this rule.
     if (account.getCurrentBalance() >= 0) {
       currentPassedAccounts.add(account);
-    } else if (false) {
+      return true;
+    } else {
       currentFailedAccounts.add(account);
+      return false;
     }
   }
 }