Allow not passing a --standard argument and use the default configuration instead.

Author: zaantar

README.md

@@ -29,7 +29,9 @@ Options:
 - `--start_revision=<arg>`: First (older) revision number/commit hash    
 - `--end_revision=<arg>`: Second (newer) revision number/commit hash    
 - `--tolerance[=<arg>]`: Last level of issues that will be tolerated. Accepted values are blockers | warnings | notes | none.     
-- `--standard[=<arg>]`: Name of the phpcs standard to use: 'WordPress', 'WordPress-VIP', 'WordPress-Core', 'WordPress-Docs', 'WordPress-Extra', 'Toolset'
+- `--standard[=<arg>]`: Name of the phpcs standard to use: 'WordPress', 'WordPress-VIP', 'WordPress-Core', 'WordPress-Docs', 'WordPress-Extra' or 'Toolset'. 
+    If you omit this argument, a [default configuration file](https://github.com/squizlabs/PHP_CodeSniffer/wiki/Advanced-Usage#using-a-default-configuration-file)
+    will be used. 
 - `--log_level[=<arg>]`: Control verbosity by passing a number from 0 (most verbose) to 2 (least verbose, only errors).
 - `--ignore_space_changes`: Whitespace changes will be ignored when git is used to produce the diff.
 - `--sniff_unstaged`: Inspect unstaged changes in the working directory against the latest commit (HEAD). `--start_revision` and `--end_revision` will be ignored in this case.

bin/phpcs-diff

@@ -56,8 +56,7 @@ $getopt->getOption( 'standard', true )
 	->setMode( \GetOpt\GetOpt::OPTIONAL_ARGUMENT )
 	->setValidation( function( $value ) {
 		return in_array( $value, [ 'WordPress', 'WordPress-VIP', 'WordPress-Core', 'WordPress-Docs', 'WordPress-Extra', 'Toolset' ] );
-	} )
-	->setDefaultValue( 'WordPress' );
+	} );
 
 $getopt->getOption( 'log_level', true )
 	->setMode( \GetOpt\GetOpt::OPTIONAL_ARGUMENT )

inc/Main.php

@@ -166,10 +166,14 @@ private function parse_phpcs_results( $phpcs_results ) {
 	}
 
 	private function diff_results_for_two_revs( $new_rev_results, $old_rev_results, LineMapping $line_mapping ) {
-
 		$new_rev_results = $this->parse_phpcs_results( $new_rev_results );
 		$old_rev_results = $this->parse_phpcs_results( $old_rev_results );
 
+		if( empty( $old_rev_results ) ) {
+			// Nothing to compare against. All issues in the new revision are new issues.
+			return $new_rev_results;
+		}
+
 		$last_old_line_number = max( array_keys( $old_rev_results ) );
 		$line_mapping->build_mapping( $last_old_line_number );
 

inc/backends/Git.php

@@ -189,11 +189,17 @@ public function run_phpcs_for_file_at_revision( $filename, $revision, $phpcs_com
 			);
 		}
 
+		if( null !== $phpcs_standard ) {
+			$phpcs_standard_arg = sprintf( '--standard=%s', escapeshellarg( $phpcs_standard ) );
+		} else {
+			$phpcs_standard_arg = '';
+		}
+
 		$phpcs_command = sprintf(
-			'%s --report=json --runtime-set installed_paths %s --standard=%s --stdin-path=%s -',
+			'%s --report=json --runtime-set installed_paths %s %s --stdin-path=%s -',
 			escapeshellcmd( $phpcs_command ),
 			escapeshellarg( $standards_location ),
-			escapeshellarg( $phpcs_standard ),
+			$phpcs_standard_arg,
 			escapeshellarg( $filename )
 		);
 

inc/resultparser/ResultParser.php

@@ -26,7 +26,12 @@ public function parse( $raw_phpcs_output ) {
 
 		$file = array_pop( $phpcs_json['files'] );
 
-		if( ! array_key_exists( 'messages', $file ) || ! is_array( $file['messages'] ) ) {
+		if( ! is_array( $file ) || ! array_key_exists( 'messages', $file ) ) {
+			// Happens for perfect code :)
+			return [];
+		}
+
+		if( ! is_array( $file['messages'] ) ) {
 			throw new \RuntimeException( 'Unable to parse the phpcs output: ' . $raw_phpcs_output );
 		}