Skip to content

Commit b592e8c

Browse files
committed
Improvements in Main::run() in order to also process files that have only changed lines and no added new ones.
1 parent 3f9a526 commit b592e8c

File tree

1 file changed

+14
-19
lines changed

1 file changed

+14
-19
lines changed

inc/Main.php

Lines changed: 14 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -99,28 +99,23 @@ public function run( $oldest_rev, $newest_rev, $directory = '' ) {
9999
$found_issues = array();
100100
$found_issues_count = 0;
101101
foreach( $file_diffs as $filename => $file_info ) {
102-
if ( true === array_key_exists( 'lines_added', $file_info ) && $file_info['lines_added'] > 0 ) {
103-
$line_mapping = new LineMapping();
104-
$line_mapping->count_lines( $file_info['lines'] );
105-
if ( ! $line_mapping->has_actionable_changes() ) {
106-
continue;
107-
}
102+
$line_mapping = new LineMapping();
103+
$line_mapping->count_lines( $file_info['lines'] );
104+
if ( ! $line_mapping->has_actionable_changes() ) {
105+
continue;
106+
}
108107

109-
if ( true === array_key_exists( 'is_new_file', $file_info ) && true === $file_info['is_new_file'] ) {
110-
$is_new_file = true;
111-
} else {
112-
$is_new_file = false;
113-
}
114-
$processed_file = $this->process_file(
115-
$directory . '/' . $filename, $oldest_rev, $newest_rev, $is_new_file, $line_mapping
116-
);
108+
$is_new_file = ( array_key_exists( 'is_new_file', $file_info ) && true === $file_info['is_new_file'] );
117109

118-
if ( false === $processed_file || true === empty( $processed_file ) ) {
119-
continue;
120-
}
121-
$found_issues[$filename] = $processed_file;
122-
$found_issues_count += count( $processed_file );
110+
$processed_file = $this->process_file(
111+
$directory . '/' . $filename, $oldest_rev, $newest_rev, $is_new_file, $line_mapping
112+
);
113+
114+
if ( false === $processed_file || empty( $processed_file ) ) {
115+
continue;
123116
}
117+
$found_issues[ $filename ] = $processed_file;
118+
$found_issues_count += count( $processed_file );
124119
}
125120

126121
return $found_issues;

0 commit comments

Comments
 (0)